This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 3c6b4e489db49a51ee8117fecc3e748c62a79582 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Jun 16 07:53:08 2024 -0400 Remove InvalidKeySpecException from AuthenticatingIMAPClient.auth(AUTH_METHOD, String, String) never throws, it's not thrown Note this change is binary compatible --- src/changes/changes.xml | 1 + .../java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 094269c7..166008a0 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -66,6 +66,7 @@ The <action> type attribute can be add,update,fix,remove. <body> <release version="3.11.2" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required."> <!-- FIX --> + <action type="fix" dev="ggregory" due-to="Gary Gregory">Remove InvalidKeySpecException from AuthenticatingIMAPClient.auth(AUTH_METHOD, String, String) never throws, it's not thrown.</action> <!-- ADD --> <!-- UPDATE --> <action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump org.apache.commons:commons-parent from 70 to 71 #261.</action> diff --git a/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java b/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java index 8210f658..fa6113d3 100644 --- a/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java +++ b/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java @@ -149,10 +149,9 @@ public class AuthenticatingIMAPClient extends IMAPSClient { * @throws IOException If an I/O error occurs while either sending a command to the server or receiving a reply from the server. * @throws NoSuchAlgorithmException If the CRAM hash algorithm cannot be instantiated by the Java runtime system. * @throws InvalidKeyException If the CRAM hash algorithm failed to use the given password. - * @throws InvalidKeySpecException If the CRAM hash algorithm failed to use the given password. */ public boolean auth(final AuthenticatingIMAPClient.AUTH_METHOD method, final String user, final String password) - throws IOException, NoSuchAlgorithmException, InvalidKeyException, InvalidKeySpecException { + throws IOException, NoSuchAlgorithmException, InvalidKeyException { if (!IMAPReply.isContinuation(sendCommand(IMAPCommand.AUTHENTICATE, method.getAuthName()))) { return false; }