(commons-lang) 04/06: Simplify test and add missing cases

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit e9bd1832321e1fe3bc851de2e07393e311ff9506
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed May 29 16:25:25 2024 -0400

    Simplify test and add missing cases
---
 .../commons/lang3/function/ConsumersTest.java      | 27 +++++-----------------
 1 file changed, 6 insertions(+), 21 deletions(-)

diff --git a/src/test/java/org/apache/commons/lang3/function/ConsumersTest.java 
b/src/test/java/org/apache/commons/lang3/function/ConsumersTest.java
index a4a4ab64e..d8f800cb3 100644
--- a/src/test/java/org/apache/commons/lang3/function/ConsumersTest.java
+++ b/src/test/java/org/apache/commons/lang3/function/ConsumersTest.java
@@ -17,9 +17,9 @@
 
 package org.apache.commons.lang3.function;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Consumer;
 import java.util.stream.Stream;
 
@@ -31,31 +31,16 @@ import org.junit.jupiter.api.Test;
  */
 public class ConsumersTest extends AbstractLangTest {
 
-    private static final class TestConsumer<T> implements Consumer<T> {
-        private boolean isCalled;
-
-        @Override
-        public void accept(T t) {
-            isCalled = true;
-        }
-    }
-
     /**
      * Tests {@link Consumers#accept(Consumer, Object)}.
      */
     @Test
     public void testAccept() {
-        final StringBuilder builder = new StringBuilder("foo");
-        Consumers.accept(sb -> sb.append("-bar"), builder);
-        assertEquals("foo-bar", builder.toString());
-
-        final TestConsumer<String> consumer = new TestConsumer<>();
-        Consumers.accept(consumer, null);
-        assertTrue(consumer.isCalled);
-
-        final StringBuilder builder2 = new StringBuilder("foo");
-        Consumers.accept(null, builder2);
-        assertEquals("foo", builder2.toString());
+        final AtomicBoolean bool = new AtomicBoolean();
+        Consumers.accept(bool::set, true);
+        assertTrue(bool.get());
+        Consumers.accept(null, "");
+        Consumers.accept(null, null);
     }
 
     /**