(commons-net) branch master updated: Test passes on Windows but not on Linux

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git


The following commit(s) were added to refs/heads/master by this push:
     new 671013f9 Test passes on Windows but not on Linux
671013f9 is described below

commit 671013f97ab535fe3456f46be1dd39c7933ccae6
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue May 28 17:44:42 2024 -0400

    Test passes on Windows but not on Linux
---
 src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java | 2 --
 src/test/java/org/apache/commons/net/tftp/TFTPTest.java       | 4 +---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java 
b/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java
index 32ba24c2..73154148 100644
--- a/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java
+++ b/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java
@@ -96,11 +96,9 @@ public final class TFTPDataPacket extends TFTPPacket {
      */
     public TFTPDataPacket(final InetAddress destination, final int port, final 
int blockNumber, final byte[] data, final int offset, final int length) {
         super(TFTPPacket.DATA, destination, port);
-
         this.blockNumber = blockNumber;
         this.data = data;
         this.offset = offset;
-
         this.length = Math.min(length, MAX_DATA_LENGTH);
     }
 
diff --git a/src/test/java/org/apache/commons/net/tftp/TFTPTest.java 
b/src/test/java/org/apache/commons/net/tftp/TFTPTest.java
index 382e3f0c..d9826775 100644
--- a/src/test/java/org/apache/commons/net/tftp/TFTPTest.java
+++ b/src/test/java/org/apache/commons/net/tftp/TFTPTest.java
@@ -124,10 +124,8 @@ public class TFTPTest extends TestCase {
 
     public void testSend() throws IOException {
         try (TFTP tftp = new TFTP()) {
-            final TFTPDataPacket packet = new 
TFTPDataPacket(InetAddress.getLocalHost(), 0, 0, new byte[0]);
-            assertThrows(NullPointerException.class, () -> tftp.send(packet));
             tftp.open();
-            tftp.send(packet);
+            tftp.send(new TFTPDataPacket(InetAddress.getLocalHost(), 
tftp.getLocalPort(), 0, new byte[10]));
         }
     }