(commons-net) 01/04: Fill in tests

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git

commit d778106e7e56c68a0ef9ea8572ca93f9de9cdf86
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Mon May 27 09:21:39 2024 -0400

    Fill in tests
---
 .../org/apache/commons/net/util/Base64Test.java     | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/test/java/org/apache/commons/net/util/Base64Test.java 
b/src/test/java/org/apache/commons/net/util/Base64Test.java
index 70c23873..1c018000 100644
--- a/src/test/java/org/apache/commons/net/util/Base64Test.java
+++ b/src/test/java/org/apache/commons/net/util/Base64Test.java
@@ -100,7 +100,7 @@ public class Base64Test {
 
     @Test
     public void testDecodeBase64ByteArray() {
-        checkDecoders("light w", new byte[] {'b', 'G', 'l', 'n', 'a', 'H', 
'Q', 'g', 'd', 'w', '=', '='});
+        checkDecoders("light w", new byte[] { 'b', 'G', 'l', 'n', 'a', 'H', 
'Q', 'g', 'd', 'w', '=', '=' });
     }
 
     @Test
@@ -110,7 +110,7 @@ public class Base64Test {
 
     @Test
     public void testDecodeByteArray() {
-        checkDecoders("foobar", new byte[] {'Z', 'm', '9', 'v', 'Y', 'm', 'F', 
'y'});
+        checkDecoders("foobar", new byte[] { 'Z', 'm', '9', 'v', 'Y', 'm', 
'F', 'y' });
     }
 
     @Test
@@ -135,6 +135,12 @@ public class Base64Test {
         assertEquals(bi, 
Base64.decodeInteger(getJreEncoder().encode(bi.toByteArray())));
     }
 
+    private void testEncodeInteger(final BigInteger bi) {
+        final byte[] decodedBytes = 
getJreDecoder().decode(Base64.encodeInteger(bi));
+        final BigInteger decoded = decodedBytes.length == 0 ? BigInteger.ZERO 
: new BigInteger(decodedBytes);
+        assertEquals(bi, decoded);
+    }
+
     @Test
     public void testDecodeNullString() {
         final Base64 base64 = new Base64();
@@ -210,7 +216,7 @@ public class Base64Test {
 
     @Test
     public void testEncodeBase64Chunked() {
-        final byte[] bytesToEncode = {'f', 'o', 'o', 'b', 'a', 'r'};
+        final byte[] bytesToEncode = { 'f', 'o', 'o', 'b', 'a', 'r' };
         final byte[] encodedData = Base64.encodeBase64Chunked(bytesToEncode);
         assertEquals("Zm9vYmFy\r\n", new String(encodedData, 
StandardCharsets.UTF_8));
     }
@@ -257,14 +263,15 @@ public class Base64Test {
     @Test
     public void testEncodeByteArray() {
         final Base64 base64 = new Base64();
-        final byte[] bytesToEncode = {'l', 'i', 'g', 'h', 't', ' ', 'w', 'o', 
'r'};
+        final byte[] bytesToEncode = { 'l', 'i', 'g', 'h', 't', ' ', 'w', 'o', 
'r' };
         assertEquals("bGlnaHQgd29y\r\n", new 
String(base64.encode(bytesToEncode), StandardCharsets.UTF_8));
     }
 
     @Test
-    @Ignore
     public void testEncodeInteger() {
-        fail("Not yet implemented");
+        testEncodeInteger(BigInteger.ONE);
+        testEncodeInteger(BigInteger.TEN);
+        testEncodeInteger(BigInteger.ZERO);
     }
 
     @Test
@@ -276,7 +283,7 @@ public class Base64Test {
     @Test
     public void testEncodeToString() {
         final Base64 base64 = new Base64();
-        final byte[] bytesToEncode = {'l', 'i', 'g', 'h', 't', ' ', 'w', 'o', 
'r'};
+        final byte[] bytesToEncode = { 'l', 'i', 'g', 'h', 't', ' ', 'w', 'o', 
'r' };
         assertEquals("bGlnaHQgd29y\r\n", base64.encodeToString(bytesToEncode));
     }