This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 84788735b Use try-with-resources
84788735b is described below

commit 84788735bdfa00d79bc2fc053ee0b14558c377a1
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri May 17 10:23:21 2024 -0400

    Use try-with-resources
---
 .../compress/harmony/pack200/ArchiveTest.java      | 29 +++++++++++-----------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/compress/harmony/pack200/ArchiveTest.java 
b/src/test/java/org/apache/commons/compress/harmony/pack200/ArchiveTest.java
index fb71c4709..2ac36b58e 100755
--- a/src/test/java/org/apache/commons/compress/harmony/pack200/ArchiveTest.java
+++ b/src/test/java/org/apache/commons/compress/harmony/pack200/ArchiveTest.java
@@ -173,22 +173,23 @@ public class ArchiveTest extends AbstractTempDirTest {
             assertNotNull(entry);
             try (InputStream ours = jarFile.getInputStream(entry)) {
 
-                final JarFile jarFile2 = new JarFile(new 
File(Segment.class.getResource("/pack200/hw.jar").toURI()));
-                final JarEntry entry2 = 
jarFile2.getJarEntry("org/apache/harmony/archive/tests/internal/pack200/HelloWorld.class");
-                assertNotNull(entry2);
+                try (JarFile jarFile2 = new JarFile(new 
File(Segment.class.getResource("/pack200/hw.jar").toURI()))) {
+                    final JarEntry entry2 = 
jarFile2.getJarEntry("org/apache/harmony/archive/tests/internal/pack200/HelloWorld.class");
+                    assertNotNull(entry2);
 
-                final InputStream expected = jarFile2.getInputStream(entry2);
+                    final InputStream expected = 
jarFile2.getInputStream(entry2);
 
-                try (BufferedReader reader1 = new BufferedReader(new 
InputStreamReader(ours));
-                        BufferedReader reader2 = new BufferedReader(new 
InputStreamReader(expected))) {
-                    String line1 = reader1.readLine();
-                    String line2 = reader2.readLine();
-                    int i = 1;
-                    while (line1 != null || line2 != null) {
-                        assertEquals(line2, line1, "Unpacked class files 
differ, i = " + i);
-                        line1 = reader1.readLine();
-                        line2 = reader2.readLine();
-                        i++;
+                    try (BufferedReader reader1 = new BufferedReader(new 
InputStreamReader(ours));
+                            BufferedReader reader2 = new BufferedReader(new 
InputStreamReader(expected))) {
+                        String line1 = reader1.readLine();
+                        String line2 = reader2.readLine();
+                        int i = 1;
+                        while (line1 != null || line2 != null) {
+                            assertEquals(line2, line1, "Unpacked class files 
differ, i = " + i);
+                            line1 = reader1.readLine();
+                            line2 = reader2.readLine();
+                            i++;
+                        }
                     }
                 }
             }

Reply via email to