This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-cli.git
commit ddb5f9a06a8ee0f9400acfcdca14d659cda821a7 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sat May 11 13:59:50 2024 -0400 Use final --- src/test/java/org/apache/commons/cli/HelpFormatterTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/commons/cli/HelpFormatterTest.java b/src/test/java/org/apache/commons/cli/HelpFormatterTest.java index e7e6cb9..0cef62e 100644 --- a/src/test/java/org/apache/commons/cli/HelpFormatterTest.java +++ b/src/test/java/org/apache/commons/cli/HelpFormatterTest.java @@ -41,7 +41,7 @@ public class HelpFormatterTest { private static final String EOL = System.lineSeparator(); static Stream<Arguments> deprecatedOptionsProvider() { - List<Arguments> lst = new ArrayList<>(); + final List<Arguments> lst = new ArrayList<>(); Option option = Option.builder("a").longOpt("aaa").desc("dddd dddd dddd") .deprecated(DeprecatedAttributes.builder().setForRemoval(true).setSince("now") .setDescription("Why why why").get()) @@ -409,14 +409,14 @@ public class HelpFormatterTest { final String lpad = hf.createPadding(leftPad); final String dpad = hf.createPadding(descPad); Options options; - String expected = lpad + "-a,--aaa"; + StringBuilder expected = new StringBuilder().append(lpad).append("-a,--aaa"); options = new Options().addOption(option); if (expectedTxt.length() > 0) { - expected = expected + dpad + expectedTxt; + expected.append(dpad).append(expectedTxt); } hf.renderOptions(sb, 160, options, leftPad, descPad); - assertEquals(expected, sb.toString()); + assertEquals(expected.toString(), sb.toString()); } @Test