This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new 24e8d148 Add Whitespace checks
24e8d148 is described below

commit 24e8d148e775e525e8e9d383577a028aabfb59ea
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat May 4 16:35:51 2024 -0400

    Add Whitespace checks
---
 src/conf/checkstyle.xml | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index 4fe6af87..1562a81b 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -5,39 +5,29 @@
   in writing, software distributed under the License is distributed on an "AS 
IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied. See 
   the License for the specific language governing permissions and limitations 
under the License. -->
 <!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" 
"https://checkstyle.org/dtds/configuration_1_3.dtd";>
-
 <!-- Checkstyle checks configured for Maven. -->
-
 <module name="Checker">
-
   <!-- Checks that a package.html file exists for each package. -->
   <!-- See http://checkstyle.sf.net/config_javadoc.html#PackageHtml -->
   <module name="JavadocPackage" />
-
   <!-- Checks whether files end with a new line. -->
   <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
   <module name="NewlineAtEndOfFile" />
-
   <!-- Checks that property files contain the same keys. -->
   <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
   <module name="Translation" />
-
   <!-- Checks for Size Violations. -->
   <!-- See http://checkstyle.sf.net/config_sizes.html -->
   <module name="FileLength">
     <!-- Increase default -->
     <property name="max" value="2700" />
   </module>
-
   <!-- No tabs allowed! -->
   <module name="FileTabCharacter" />
-
   <module name="TreeWalker">
-
     <!-- ************************************************************** -->
     <!-- Checks that are different from the sun coding conventions ones -->
     <!-- ************************************************************** -->
-
     <property name="tabWidth" value="4" />
     <!-- suspend formatting checks, for now <module name="LeftCurly"> 
<property name="option" value="eol"/> </module> <module name="RightCurly"> 
<property name="option" 
       value="alone"/> </module> <module name="LineLength"> <property 
name="max" value="132"/> </module> <module name="MethodLength"> <property 
name="max" value="175"/> 
@@ -45,11 +35,9 @@
     <module name="ConstantName">
       <property name="format" value="log|^[a-zA-Z][a-zA-Z0-9_]*$" />
     </module>
-
     <!-- ************************************************************** -->
     <!-- Default Sun coding conventions checks -->
     <!-- ************************************************************** -->
-
     <!-- Checks for Javadoc comments. -->
     <!-- See http://checkstyle.sf.net/config_javadoc.html -->
     <module name="JavadocMethod">
@@ -62,7 +50,6 @@
       <property name="scope" value="protected" />
     </module>
     <!-- <module name="JavadocVariable"> <property name="scope" 
value="protected"/> </module> -->
-
     <!-- Checks for Naming Conventions. -->
     <!-- See http://checkstyle.sf.net/config_naming.html -->
     <module name="LocalFinalVariableName" />
@@ -73,21 +60,21 @@
     <!-- <module name="StaticVariableName"/> -->
     <module name="TypeName" />
     <!-- <module name="MemberName"/> -->
-
     <!-- Checks for imports -->
     <!-- See http://checkstyle.sf.net/config_import.html -->
     <module name="AvoidStarImport" />
     <module name="IllegalImport" /> <!-- defaults to sun.* packages -->
     <module name="RedundantImport" />
     <module name="UnusedImports" />
-
     <!-- Suspend, for now <module name="ParameterNumber"/> -->
 
     <!-- Checks for whitespace -->
     <!-- See http://checkstyle.sf.net/config_whitespace.html -->
     <module name="EmptyForIteratorPad" />
-    <!-- <module name="NoWhitespaceAfter"/> <module 
name="NoWhitespaceBefore"/> <module name="OperatorWrap"/> <module 
name="WhitespaceAfter"/> <module name="WhitespaceAround"/> -->
-
+    <!-- <module name="OperatorWrap"/> -->
+    <module name="WhitespaceAfter"/>
+    <module name="WhitespaceAround"/>
+    <module name="WhitespaceAroundCheck"/> 
     <!-- Modifier Checks -->
     <!-- See http://checkstyle.sf.net/config_modifiers.html -->
     <!-- <module name="ModifierOrder"/> <module name="RedundantModifier"/> -->

Reply via email to