This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
The following commit(s) were added to refs/heads/master by this push: new 5b507bb8 Use Checkstyle WhitespaceAfter 5b507bb8 is described below commit 5b507bb8fd5c32ef039a06bd5e56a90a905052b5 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sat May 4 15:36:31 2024 -0400 Use Checkstyle WhitespaceAfter --- .../commons/jexl3/internal/introspection/BooleanGetExecutor.java | 2 +- .../commons/jexl3/internal/introspection/DuckGetExecutor.java | 2 +- .../commons/jexl3/internal/introspection/DuckSetExecutor.java | 2 +- .../apache/commons/jexl3/internal/introspection/MethodExecutor.java | 2 +- .../commons/jexl3/internal/introspection/PropertyGetExecutor.java | 2 +- .../commons/jexl3/internal/introspection/PropertySetExecutor.java | 2 +- src/test/java/org/apache/commons/jexl3/ArithmeticOperatorTest.java | 2 +- src/test/java/org/apache/commons/jexl3/CachePerformanceTest.java | 6 +++--- src/test/java/org/apache/commons/jexl3/ClassCreator.java | 4 ++-- src/test/java/org/apache/commons/jexl3/Issues200Test.java | 2 +- src/test/java/org/apache/commons/jexl3/IssuesTest.java | 4 ++-- src/test/java/org/apache/commons/jexl3/internal/Util.java | 2 +- .../apache/commons/jexl3/internal/introspection/MethodKeyTest.java | 2 +- .../org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java | 2 +- 14 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/BooleanGetExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/BooleanGetExecutor.java index 3e8f04a9..b1fc8cc0 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/BooleanGetExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/BooleanGetExecutor.java @@ -76,7 +76,7 @@ public final class BooleanGetExecutor extends AbstractExecutor.Get { try { return method.invoke(obj, (Object[]) null); } catch (final IllegalAccessException xill) { - return TRY_FAILED;// fail + return TRY_FAILED; // fail } catch (final InvocationTargetException xinvoke) { throw JexlException.tryFailed(xinvoke); // throw } diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckGetExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckGetExecutor.java index 37877097..2458afea 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckGetExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckGetExecutor.java @@ -81,7 +81,7 @@ public final class DuckGetExecutor extends AbstractExecutor.Get { final Object[] args = {property}; return method.invoke(obj, args); } catch (IllegalAccessException | IllegalArgumentException xill) { - return TRY_FAILED;// fail + return TRY_FAILED; // fail } catch (final InvocationTargetException xinvoke) { throw JexlException.tryFailed(xinvoke); // throw } diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckSetExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckSetExecutor.java index 2e217358..799533cc 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckSetExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/DuckSetExecutor.java @@ -100,7 +100,7 @@ public final class DuckSetExecutor extends AbstractExecutor.Set { method.invoke(obj, args); return value; } catch (IllegalAccessException | IllegalArgumentException xill) { - return TRY_FAILED;// fail + return TRY_FAILED; // fail } catch (final InvocationTargetException xinvoke) { throw JexlException.tryFailed(xinvoke); // throw } diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java index b383113f..1918b8ee 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java @@ -102,7 +102,7 @@ public final class MethodExecutor extends AbstractExecutor.Method { try { return invoke(obj, args); } catch (IllegalAccessException | IllegalArgumentException xill) { - return TRY_FAILED;// fail + return TRY_FAILED; // fail } catch (final InvocationTargetException xinvoke) { throw JexlException.tryFailed(xinvoke); // throw } diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertyGetExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertyGetExecutor.java index a9e55f7f..c4f0e303 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertyGetExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertyGetExecutor.java @@ -73,7 +73,7 @@ public final class PropertyGetExecutor extends AbstractExecutor.Get { try { return method.invoke(o, (Object[]) null); } catch (IllegalAccessException | IllegalArgumentException xill) { - return TRY_FAILED;// fail + return TRY_FAILED; // fail } catch (final InvocationTargetException xinvoke) { throw JexlException.tryFailed(xinvoke); // throw } diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertySetExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertySetExecutor.java index dce63627..95bb8686 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertySetExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/PropertySetExecutor.java @@ -105,7 +105,7 @@ public class PropertySetExecutor extends AbstractExecutor.Set { try { return invoke(o, value); } catch (IllegalAccessException | IllegalArgumentException xill) { - return TRY_FAILED;// fail + return TRY_FAILED; // fail } catch (final InvocationTargetException xinvoke) { throw JexlException.tryFailed(xinvoke); // throw } diff --git a/src/test/java/org/apache/commons/jexl3/ArithmeticOperatorTest.java b/src/test/java/org/apache/commons/jexl3/ArithmeticOperatorTest.java index ba36fbc2..eddebb51 100644 --- a/src/test/java/org/apache/commons/jexl3/ArithmeticOperatorTest.java +++ b/src/test/java/org/apache/commons/jexl3/ArithmeticOperatorTest.java @@ -81,7 +81,7 @@ public class ArithmeticOperatorTest extends JexlTestCase { return cal.get(Calendar.DAY_OF_MONTH); } // Otherwise treat as format mask - final SimpleDateFormat df = new SimpleDateFormat(key);//, dfs); + final SimpleDateFormat df = new SimpleDateFormat(key); //, dfs); return df.format(date); } catch (final Exception ex) { diff --git a/src/test/java/org/apache/commons/jexl3/CachePerformanceTest.java b/src/test/java/org/apache/commons/jexl3/CachePerformanceTest.java index 86c23052..32841dea 100644 --- a/src/test/java/org/apache/commons/jexl3/CachePerformanceTest.java +++ b/src/test/java/org/apache/commons/jexl3/CachePerformanceTest.java @@ -49,11 +49,11 @@ import java.util.concurrent.Future; */ public class CachePerformanceTest { /** Number of test loops. */ - private static final int LOOPS = 10;//0; + private static final int LOOPS = 10; //0; /** Number of different scripts. */ - private static final int SCRIPTS = 800;//0; + private static final int SCRIPTS = 800; //0; /** Cache capacity. */ - private static final int CACHED = 500;//0; + private static final int CACHED = 500; //0; /** Number of times each script is evaluated. */ private static final int HIT = 5; /** Number of concurrent threads. */ diff --git a/src/test/java/org/apache/commons/jexl3/ClassCreator.java b/src/test/java/org/apache/commons/jexl3/ClassCreator.java index 1e0b51ef..566b08c1 100644 --- a/src/test/java/org/apache/commons/jexl3/ClassCreator.java +++ b/src/test/java/org/apache/commons/jexl3/ClassCreator.java @@ -39,10 +39,10 @@ import javax.tools.ToolProvider; */ public class ClassCreator { - public static final boolean canRun = true;//comSunToolsJavacMain(); + public static final boolean canRun = true; //comSunToolsJavacMain(); static final String JEXL_PACKAGE = "org.apache.commons.jexl3"; static final String GEN_PACKAGE = "org.apache.commons.jexl3.generated"; - static final String GEN_PATH = "/" + GEN_PACKAGE.replace(".", "/");///org/apache/commons/jexl3/generated"; + static final String GEN_PATH = "/" + GEN_PACKAGE.replace(".", "/"); ///org/apache/commons/jexl3/generated"; static final String GEN_CLASS = GEN_PACKAGE + "."; /** * Check if we can invoke Sun's Java compiler. diff --git a/src/test/java/org/apache/commons/jexl3/Issues200Test.java b/src/test/java/org/apache/commons/jexl3/Issues200Test.java index 1e79cec0..a08a5355 100644 --- a/src/test/java/org/apache/commons/jexl3/Issues200Test.java +++ b/src/test/java/org/apache/commons/jexl3/Issues200Test.java @@ -722,7 +722,7 @@ public class Issues200Test extends JexlTestCase { @Test public void test279() throws Exception { - final Log logger = null;//LogFactory.getLog(Issues200Test.class); + final Log logger = null; //LogFactory.getLog(Issues200Test.class); Object result; JexlScript script; final JexlContext ctxt = new Context279(); diff --git a/src/test/java/org/apache/commons/jexl3/IssuesTest.java b/src/test/java/org/apache/commons/jexl3/IssuesTest.java index b8954acb..f402e9d6 100644 --- a/src/test/java/org/apache/commons/jexl3/IssuesTest.java +++ b/src/test/java/org/apache/commons/jexl3/IssuesTest.java @@ -165,7 +165,7 @@ public class IssuesTest extends JexlTestCase { JexlScript script; script = jexl.createScript("'hello world!'//commented"); Assert.assertEquals("hello world!", script.execute(ctxt)); - script = jexl.createScript("'hello world!';//commented\n'bye...'"); + script = jexl.createScript("'hello world!'; //commented\n'bye...'"); Assert.assertEquals("bye...", script.execute(ctxt)); script = jexl.createScript("'hello world!'## commented"); Assert.assertEquals("hello world!", script.execute(ctxt)); @@ -264,7 +264,7 @@ public class IssuesTest extends JexlTestCase { final JexlEvalContext ctxt = new JexlEvalContext(vars); final JexlOptions options = ctxt.getEngineOptions(); options.setStrict(true); - options.setSilent(true);// to avoid throwing JexlException on null method call + options.setSilent(true); // to avoid throwing JexlException on null method call JexlScript jscript; diff --git a/src/test/java/org/apache/commons/jexl3/internal/Util.java b/src/test/java/org/apache/commons/jexl3/internal/Util.java index 355d10e3..c5509527 100644 --- a/src/test/java/org/apache/commons/jexl3/internal/Util.java +++ b/src/test/java/org/apache/commons/jexl3/internal/Util.java @@ -142,7 +142,7 @@ public class Util { * @return an indented version of the AST */ protected static String flattenedStr(final JexlScript e) { - return "";//e.getText() + "\n" + flattenedStr(((Script)e).script); + return ""; //e.getText() + "\n" + flattenedStr(((Script)e).script); } private static String indent(JexlNode node) { diff --git a/src/test/java/org/apache/commons/jexl3/internal/introspection/MethodKeyTest.java b/src/test/java/org/apache/commons/jexl3/internal/introspection/MethodKeyTest.java index 57e62a59..2edc6fb0 100644 --- a/src/test/java/org/apache/commons/jexl3/internal/introspection/MethodKeyTest.java +++ b/src/test/java/org/apache/commons/jexl3/internal/introspection/MethodKeyTest.java @@ -102,7 +102,7 @@ public class MethodKeyTest { KEY_LIST = BY_KEY.keySet().toArray(new MethodKey[0]); } - private static final int LOOP = 3;//00; + private static final int LOOP = 3; //00; /** * Creates & inserts a key into the BY_KEY & byString map */ private static void setUpKey(final String name, final Class<?>[] parms) { diff --git a/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java b/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java index d9721a7f..26975c2d 100644 --- a/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java +++ b/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java @@ -240,7 +240,7 @@ public class JexlScriptEngineTest { final ScriptEngine engine = manager.getEngineByName("jexl3"); final Integer initialValue = 123; Assert.assertEquals(initialValue,engine.eval("123")); - Assert.assertEquals(initialValue,engine.eval("0;123"));// multiple statements + Assert.assertEquals(initialValue,engine.eval("0;123")); // multiple statements try { final Long time2 = (Long) engine.eval( "sys=context.class.forName(\"java.lang.System\");"