This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit 7ae5745214918c787a007051350b38231565f6c0
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Apr 21 09:34:53 2024 -0400
Use final
Use compact array notation
---
src/main/java/org/apache/bcel/classfile/DescendingVisitor.java | 4 ++--
src/main/java/org/apache/bcel/classfile/Record.java | 2 +-
src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java | 6 +++---
src/main/java/org/apache/bcel/classfile/Visitor.java | 2 +-
.../java/org/apache/bcel/verifier/statics/StringRepresentation.java | 4 ++--
.../java/org/apache/bcel/generic/InstructionFactoryTestCase.java | 2 +-
src/test/java/org/apache/bcel/visitors/CountingVisitor.java | 4 ++--
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/main/java/org/apache/bcel/classfile/DescendingVisitor.java
b/src/main/java/org/apache/bcel/classfile/DescendingVisitor.java
index 69fdab6c..0bcff56f 100644
--- a/src/main/java/org/apache/bcel/classfile/DescendingVisitor.java
+++ b/src/main/java/org/apache/bcel/classfile/DescendingVisitor.java
@@ -505,7 +505,7 @@ public class DescendingVisitor implements Visitor {
}
@Override
- public void visitRecord(Record record) {
+ public void visitRecord(final Record record) {
stack.push(record);
record.accept(visitor);
accept(record.getComponents());
@@ -513,7 +513,7 @@ public class DescendingVisitor implements Visitor {
}
@Override
- public void visitRecordComponent(RecordComponentInfo recordComponentInfo) {
+ public void visitRecordComponent(final RecordComponentInfo
recordComponentInfo) {
stack.push(recordComponentInfo);
recordComponentInfo.accept(visitor);
stack.pop();
diff --git a/src/main/java/org/apache/bcel/classfile/Record.java
b/src/main/java/org/apache/bcel/classfile/Record.java
index 21f17634..0ba9c491 100644
--- a/src/main/java/org/apache/bcel/classfile/Record.java
+++ b/src/main/java/org/apache/bcel/classfile/Record.java
@@ -35,7 +35,7 @@ import org.apache.bcel.util.Args;
*/
public final class Record extends Attribute {
- private static final RecordComponentInfo[] EMPTY_RCI_ARRAY = new
RecordComponentInfo[] {};
+ private static final RecordComponentInfo[] EMPTY_RCI_ARRAY = {};
private static RecordComponentInfo[] readComponents(final DataInput input,
final ConstantPool constantPool)
throws IOException {
diff --git a/src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java
b/src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java
index cf3ac1f9..af3d8552 100644
--- a/src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java
+++ b/src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java
@@ -44,7 +44,7 @@ public class RecordComponentInfo implements Node {
* @param constantPool Array of constants
* @throws IOException if an I/O error occurs.
*/
- public RecordComponentInfo(final DataInput input, ConstantPool
constantPool) throws IOException {
+ public RecordComponentInfo(final DataInput input, final ConstantPool
constantPool) throws IOException {
this.index = input.readUnsignedShort();
this.descriptorIndex = input.readUnsignedShort();
final int attributesCount = input.readUnsignedShort();
@@ -56,7 +56,7 @@ public class RecordComponentInfo implements Node {
}
@Override
- public void accept(Visitor v) {
+ public void accept(final Visitor v) {
v.visitRecordComponent(this);
}
@@ -66,7 +66,7 @@ public class RecordComponentInfo implements Node {
* @param file Output file stream
* @throws IOException if an I/O error occurs.
*/
- public void dump(DataOutputStream file) throws IOException {
+ public void dump(final DataOutputStream file) throws IOException {
file.writeShort(index);
file.writeShort(descriptorIndex);
file.writeShort(attributes.length);
diff --git a/src/main/java/org/apache/bcel/classfile/Visitor.java
b/src/main/java/org/apache/bcel/classfile/Visitor.java
index 89a72c8c..3f0a7b3c 100644
--- a/src/main/java/org/apache/bcel/classfile/Visitor.java
+++ b/src/main/java/org/apache/bcel/classfile/Visitor.java
@@ -234,7 +234,7 @@ public interface Visitor {
* @param record component to visit
* @since 6.9.0
*/
- default void visitRecordComponent(RecordComponentInfo record) {
+ default void visitRecordComponent(final RecordComponentInfo record) {
// noop
}
diff --git
a/src/main/java/org/apache/bcel/verifier/statics/StringRepresentation.java
b/src/main/java/org/apache/bcel/verifier/statics/StringRepresentation.java
index c89d1d75..d8c663b0 100644
--- a/src/main/java/org/apache/bcel/verifier/statics/StringRepresentation.java
+++ b/src/main/java/org/apache/bcel/verifier/statics/StringRepresentation.java
@@ -400,12 +400,12 @@ public class StringRepresentation extends
org.apache.bcel.classfile.EmptyVisitor
}
@Override
- public void visitRecord(Record obj) {
+ public void visitRecord(final Record obj) {
tostring = toString(obj);
}
@Override
- public void visitRecordComponent(RecordComponentInfo obj) {
+ public void visitRecordComponent(final RecordComponentInfo obj) {
tostring = toString(obj);
}
diff --git
a/src/test/java/org/apache/bcel/generic/InstructionFactoryTestCase.java
b/src/test/java/org/apache/bcel/generic/InstructionFactoryTestCase.java
index 6dda101c..6b07992d 100644
--- a/src/test/java/org/apache/bcel/generic/InstructionFactoryTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/InstructionFactoryTestCase.java
@@ -64,7 +64,7 @@ public class InstructionFactoryTestCase extends
AbstractTestCase {
@Test
public void testCreateInvokeNullArgTypes() throws Exception {
- InstructionFactory factory = new InstructionFactory(new
ClassGen(Repository.lookupClass(Object.class)));
+ final InstructionFactory factory = new InstructionFactory(new
ClassGen(Repository.lookupClass(Object.class)));
factory.createInvoke("", "", Type.VOID, null, Const.INVOKESPECIAL,
false); // Mustn't throw an NPE
}
diff --git a/src/test/java/org/apache/bcel/visitors/CountingVisitor.java
b/src/test/java/org/apache/bcel/visitors/CountingVisitor.java
index c0609843..1b95a9f9 100644
--- a/src/test/java/org/apache/bcel/visitors/CountingVisitor.java
+++ b/src/test/java/org/apache/bcel/visitors/CountingVisitor.java
@@ -490,12 +490,12 @@ public class CountingVisitor implements Visitor {
}
@Override
- public void visitRecord(Record v) {
+ public void visitRecord(final Record v) {
recordCount++;
}
@Override
- public void visitRecordComponent(RecordComponentInfo v) {
+ public void visitRecordComponent(final RecordComponentInfo v) {
recordComponentCount++;
}
