This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git

commit 1f7aa872bb9556aa31e85a844b4098af15426d24
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Apr 7 10:22:10 2024 -0400

    Better API name
---
 .../java/org/apache/commons/cli/TypeHandler.java   | 18 +++++++++---------
 .../org/apache/commons/cli/TypeHandlerTest.java    | 22 +++++++++++-----------
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/main/java/org/apache/commons/cli/TypeHandler.java 
b/src/main/java/org/apache/commons/cli/TypeHandler.java
index deb7dbf..a08c6ac 100644
--- a/src/main/java/org/apache/commons/cli/TypeHandler.java
+++ b/src/main/java/org/apache/commons/cli/TypeHandler.java
@@ -53,6 +53,15 @@ public class TypeHandler {
         resetConverters();
     }
 
+    /**
+     * Unregisters all Converters.
+     *
+     * @since 1.7.0
+     */
+    public static void clear() {
+        converterMap.clear();
+    }
+
     /**
      * Returns the class whose name is {@code className}.
      *
@@ -210,15 +219,6 @@ public class TypeHandler {
         return converterMap.getOrDefault(clazz, Converter.DEFAULT);
     }
 
-    /**
-     * Unregisters all Converters.
-     *
-     * @since 1.7.0
-     */
-    public static void noConverters() {
-        converterMap.clear();
-    }
-
     /**
      * Returns the opened FileInputStream represented by {@code string}.
      *
diff --git a/src/test/java/org/apache/commons/cli/TypeHandlerTest.java 
b/src/test/java/org/apache/commons/cli/TypeHandlerTest.java
index 69ffabb..b82a5ca 100644
--- a/src/test/java/org/apache/commons/cli/TypeHandlerTest.java
+++ b/src/test/java/org/apache/commons/cli/TypeHandlerTest.java
@@ -172,19 +172,10 @@ public class TypeHandlerTest {
     }
 
     @Test
-    public void testCreateValueExistingFile() throws Exception {
-        try (FileInputStream result = TypeHandler.createValue(
-                
"src/test/resources/org/apache/commons/cli/existing-readable.file",
-                PatternOptionBuilder.EXISTING_FILE_VALUE)) {
-            assertNotNull(result);
-        }
-    }
-
-    @Test
-    public void testNoConverters() {
+    public void testClear() {
         assertEquals(Converter.NUMBER, TypeHandler.getConverter(Number.class));
         try {
-            TypeHandler.noConverters();
+            TypeHandler.clear();
             assertEquals(Converter.DEFAULT, 
TypeHandler.getConverter(Number.class));
         } finally {
             TypeHandler.resetConverters();
@@ -192,6 +183,15 @@ public class TypeHandlerTest {
         }
     }
 
+    @Test
+    public void testCreateValueExistingFile() throws Exception {
+        try (FileInputStream result = TypeHandler.createValue(
+                
"src/test/resources/org/apache/commons/cli/existing-readable.file",
+                PatternOptionBuilder.EXISTING_FILE_VALUE)) {
+            assertNotNull(result);
+        }
+    }
+
     /* proof of equality for later tests */
     @Test
     public void testnstantiableEquals() {

Reply via email to