(commons-collections) 02/03: Rework test fixtures

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git

commit 31b411685817d85dd96c931874e0aad358f1d773
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Mar 31 10:31:52 2024 -0400

    Rework test fixtures
    
    Next, grow the amount of data tested to find bugs in the tests with
    non-repeatable map ordering
---
 .../multimap/AbstractMultiValuedMapTest.java             | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java
 
b/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java
index 1daf23195..f305cbe21 100644
--- 
a/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java
+++ 
b/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java
@@ -1257,10 +1257,18 @@ public abstract class AbstractMultiValuedMapTest<K, V> 
extends AbstractObjectTes
         assumeTrue(isRemoveSupported());
         final MultiValuedMap<K, V> map = makeFullMap();
         final Collection<V> values = map.values();
-        values.remove("v0_0");
-        values.remove("v0_1");
-        assertFalse(map.containsKey("k0"));
-        assertEquals(4, map.size());
+        final int maxK = getSampleKeySize();
+        final int maxV = getSampleCountPerKey();
+        int expectedSize = map.size();
+        for (int k = 0; k < maxK; k++) {
+            for (int v = 0; v < maxV; v++) {
+                values.remove(makeValue(k, v));
+            }
+            assertFalse(map.containsKey(makeKey(k)));
+            expectedSize -= maxV;
+            assertEquals(expectedSize, map.size());
+        }
+        assertEquals(0, map.size());
     }
 
     @Test