This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git


The following commit(s) were added to refs/heads/master by this push:
     new 21f9c6a6 Use better JUnit API
21f9c6a6 is described below

commit 21f9c6a6f7da0b8a051d61b04bd2debfe35e974f
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Mar 22 16:34:08 2024 -0400

    Use better JUnit API
---
 .../test/java/org/apache/commons/digester3/NodeCreateRuleTestCase.java | 2 +-
 .../apache/commons/digester3/OverlappingCallMethodRuleTestCase.java    | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/NodeCreateRuleTestCase.java
 
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/NodeCreateRuleTestCase.java
index f4bc9770..6c4efc10 100644
--- 
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/NodeCreateRuleTestCase.java
+++ 
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/NodeCreateRuleTestCase.java
@@ -527,7 +527,7 @@ public class NodeCreateRuleTestCase
         assertNotNull( element.getAttributeNode( "firstName" ) );
         assertEquals( "First Name", element.getAttributeNode( "firstName" 
).getNodeValue() );
         assertEquals( "firstName", element.getAttributeNode( "firstName" 
).getLocalName() );
-        assertEquals( null, element.getAttributeNode( "firstName" 
).getPrefix() );
+        assertNull( element.getAttributeNode( "firstName" ).getPrefix() );
         assertEquals( "firstName", element.getAttributeNode( "firstName" 
).getName() );
 
     }
diff --git 
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/OverlappingCallMethodRuleTestCase.java
 
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/OverlappingCallMethodRuleTestCase.java
index 869c3a58..783c7a20 100644
--- 
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/OverlappingCallMethodRuleTestCase.java
+++ 
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/OverlappingCallMethodRuleTestCase.java
@@ -20,6 +20,7 @@ package org.apache.commons.digester3;
 
 import static org.apache.commons.digester3.binder.DigesterLoader.newLoader;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 
 import java.io.IOException;
 import java.io.StringReader;
@@ -215,7 +216,7 @@ public class OverlappingCallMethodRuleTestCase
         // assertEquals("name", this.itemName);
 
         // These are what actually happens
-        assertEquals( null, this.itemId );
+        assertNull( this.itemId );
         assertEquals( "name", this.itemName );
     }
 

Reply via email to