This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 134d6d881e2cb95e2497cf1dc327aa96b45d2a2f
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Mar 16 00:39:02 2024 -0400
Add missing branch tests
---
.../commons/lang3/builder/EqualsBuilderTest.java | 126 ++++++++++++---------
1 file changed, 72 insertions(+), 54 deletions(-)
diff --git
a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
index b3808b68d..f8771f0dd 100644
--- a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
@@ -385,10 +385,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testBooleanArray() {
- boolean[] obj1 = new boolean[2];
+ final boolean[] obj1 = new boolean[2];
obj1[0] = true;
obj1[1] = false;
- boolean[] obj2 = new boolean[2];
+ final boolean[] obj2 = new boolean[2];
obj2[0] = true;
obj2[1] = false;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -397,10 +397,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final boolean[] nullArr1 = null;
+ final boolean[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -432,10 +434,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testByteArray() {
- byte[] obj1 = new byte[2];
+ final byte[] obj1 = new byte[2];
obj1[0] = 5;
obj1[1] = 6;
- byte[] obj2 = new byte[2];
+ final byte[] obj2 = new byte[2];
obj2[0] = 5;
obj2[1] = 6;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -444,10 +446,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final byte[] nullArr1 = null;
+ final byte[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -479,10 +483,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testCharArray() {
- char[] obj1 = new char[2];
+ final char[] obj1 = new char[2];
obj1[0] = 5;
obj1[1] = 6;
- char[] obj2 = new char[2];
+ final char[] obj2 = new char[2];
obj2[0] = 5;
obj2[1] = 6;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -491,10 +495,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final char[] nullArr1 = null;
+ final char[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -558,10 +564,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testDoubleArray() {
- double[] obj1 = new double[2];
+ final double[] obj1 = new double[2];
obj1[0] = 5;
obj1[1] = 6;
- double[] obj2 = new double[2];
+ final double[] obj2 = new double[2];
obj2[0] = 5;
obj2[1] = 6;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -570,10 +576,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final double[] nullArr1 = null;
+ final double[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -608,10 +616,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testFloatArray() {
- float[] obj1 = new float[2];
+ final float[] obj1 = new float[2];
obj1[0] = 5;
obj1[1] = 6;
- float[] obj2 = new float[2];
+ final float[] obj2 = new float[2];
obj2[0] = 5;
obj2[1] = 6;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -620,10 +628,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final float[] nullArr1 = null;
+ final float[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -655,10 +665,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testIntArray() {
- int[] obj1 = new int[2];
+ final int[] obj1 = new int[2];
obj1[0] = 5;
obj1[1] = 6;
- int[] obj2 = new int[2];
+ final int[] obj2 = new int[2];
obj2[0] = 5;
obj2[1] = 6;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -667,10 +677,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final int[] nullArr1 = null;
+ final int[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -721,10 +733,10 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testLongArray() {
- long[] obj1 = new long[2];
+ final long[] obj1 = new long[2];
obj1[0] = 5L;
obj1[1] = 6L;
- long[] obj2 = new long[2];
+ final long[] obj2 = new long[2];
obj2[0] = 5L;
obj2[1] = 6L;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -733,10 +745,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final long[] nullArr1 = null;
+ final long[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -942,11 +956,11 @@ public class EqualsBuilderTest extends AbstractLangTest {
@Test
public void testObjectArray() {
- TestObject[] obj1 = new TestObject[3];
+ final TestObject[] obj1 = new TestObject[3];
obj1[0] = new TestObject(4);
obj1[1] = new TestObject(5);
obj1[2] = null;
- TestObject[] obj2 = new TestObject[3];
+ final TestObject[] obj2 = new TestObject[3];
obj2[0] = new TestObject(4);
obj2[1] = new TestObject(5);
obj2[2] = null;
@@ -964,10 +978,12 @@ public class EqualsBuilderTest extends AbstractLangTest {
obj1[2] = null;
assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final TestObject[] nullArr1 = null;
+ final TestObject[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
@@ -1351,10 +1367,10 @@ public class EqualsBuilderTest extends AbstractLangTest
{
@Test
public void testShortArray() {
- short[] obj1 = new short[2];
+ final short[] obj1 = new short[2];
obj1[0] = 5;
obj1[1] = 6;
- short[] obj2 = new short[2];
+ final short[] obj2 = new short[2];
obj2[0] = 5;
obj2[1] = 6;
assertTrue(new EqualsBuilder().append(obj1, obj1).isEquals());
@@ -1363,10 +1379,12 @@ public class EqualsBuilderTest extends AbstractLangTest
{
assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
assertFalse(new EqualsBuilder().append(obj1, obj2).append(obj1,
obj1).isEquals());
- obj2 = null;
- assertFalse(new EqualsBuilder().append(obj1, obj2).isEquals());
- obj1 = null;
- assertTrue(new EqualsBuilder().append(obj1, obj2).isEquals());
+ final short[] nullArr1 = null;
+ final short[] nullArr2 = null;
+ assertFalse(new EqualsBuilder().append(obj1, nullArr2).isEquals());
+ assertFalse(new EqualsBuilder().append(nullArr1, obj2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr2).isEquals());
+ assertTrue(new EqualsBuilder().append(nullArr1, nullArr1).isEquals());
}
@Test
