(commons-lang) 01/02: Use final

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit 71d6f222ec42d448c60e0e8f8b9c738c23fcd4cc
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Feb 18 08:51:56 2024 -0500

    Use final
---
 src/main/java/org/apache/commons/lang3/ObjectUtils.java      | 12 +++---------
 src/main/java/org/apache/commons/lang3/StringUtils.java      |  6 ++----
 .../org/apache/commons/lang3/event/EventListenerSupport.java |  2 +-
 3 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/ObjectUtils.java 
b/src/main/java/org/apache/commons/lang3/ObjectUtils.java
index ccd8db057..083773943 100644
--- a/src/main/java/org/apache/commons/lang3/ObjectUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ObjectUtils.java
@@ -262,9 +262,7 @@ public class ObjectUtils {
                         + obj.getClass().getName(), e.getCause());
                 }
             }
-            @SuppressWarnings("unchecked") // OK because input is of type T
-            final T checked = (T) result;
-            return checked;
+            return (T) result;
         }
 
         return null;
@@ -1109,9 +1107,7 @@ public class ObjectUtils {
         Objects.requireNonNull(comparator, "comparator");
         final TreeSet<T> treeSet = new TreeSet<>(comparator);
         Collections.addAll(treeSet, items);
-        @SuppressWarnings("unchecked") //we know all items added were T 
instances
-        final T result = (T) treeSet.toArray()[(treeSet.size() - 1) / 2];
-        return result;
+        return (T) treeSet.toArray()[(treeSet.size() - 1) / 2];
     }
 
     /**
@@ -1130,9 +1126,7 @@ public class ObjectUtils {
         Validate.noNullElements(items);
         final TreeSet<T> sort = new TreeSet<>();
         Collections.addAll(sort, items);
-        @SuppressWarnings("unchecked") //we know all items added were T 
instances
-        final T result = (T) sort.toArray()[(sort.size() - 1) / 2];
-        return result;
+        return (T) sort.toArray()[(sort.size() - 1) / 2];
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java 
b/src/main/java/org/apache/commons/lang3/StringUtils.java
index a804076c3..190e32474 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -623,8 +623,7 @@ public class StringUtils {
             return str;
         }
         str = leftPad(str, strLen + pads / 2, padChar);
-        str = rightPad(str, size, padChar);
-        return str;
+        return rightPad(str, size, padChar);
     }
 
     /**
@@ -666,8 +665,7 @@ public class StringUtils {
             return str;
         }
         str = leftPad(str, strLen + pads / 2, padStr);
-        str = rightPad(str, size, padStr);
-        return str;
+        return rightPad(str, size, padStr);
     }
 
     /**
diff --git 
a/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java 
b/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java
index c6ea4bc6d..e2f94f67d 100644
--- a/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java
+++ b/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java
@@ -91,7 +91,7 @@ public class EventListenerSupport<L> implements Serializable {
          * @param handler Handles Throwables.
          * @since 3.15.0
          */
-        public ProxyInvocationHandler(FailableConsumer<Throwable, 
IllegalAccessException> handler) {
+        public ProxyInvocationHandler(final FailableConsumer<Throwable, 
IllegalAccessException> handler) {
             this.handler = Objects.requireNonNull(handler);
         }