This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 04c01da0e5dbc0893ad7d43151466a089307a44b Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Mon Feb 12 11:25:24 2024 -0500 Javadoc --- .../apache/commons/compress/archivers/zip/ExtraFieldUtils.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java b/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java index 4cbb6dd79..7278d2a4d 100644 --- a/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java +++ b/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java @@ -28,8 +28,6 @@ import java.util.zip.ZipException; /** * {@link ZipExtraField} related methods. - * - * @NotThreadSafe because the HashMap is not synchronized. */ // CheckStyle:HideUtilityClassConstructorCheck OFF (bc) public class ExtraFieldUtils { @@ -369,7 +367,7 @@ public class ExtraFieldUtils { } /** - * Registers a ZipExtraField implementation. + * Registers a ZipExtraField implementation, overriding a matching existing entry. * <p> * The given class must have a no-arg constructor and implement the {@link ZipExtraField ZipExtraField interface}. * </p> @@ -383,8 +381,8 @@ public class ExtraFieldUtils { public static void register(final Class<?> clazz) { try { final Constructor<? extends ZipExtraField> constructor = clazz.asSubclass(ZipExtraField.class).getConstructor(); - final ZipExtraField ze = constructor.newInstance(); - IMPLEMENTATIONS.put(ze.getHeaderId(), () -> { + final ZipExtraField zef = clazz.asSubclass(ZipExtraField.class).getConstructor().newInstance(); + IMPLEMENTATIONS.put(zef.getHeaderId(), () -> { try { return constructor.newInstance(); } catch (final InstantiationException | IllegalAccessException e) {