This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git
commit 6a28fe578c91e40bbab0b2efe6565ded1ddbd048
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Dec 29 10:26:56 2023 -0500
Add SpotBugs to default goal
---
pom.xml | 2 +-
src/conf/findbugs-exclude-filter.xml | 15 +++++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index c705101f..6e45ca75 100644
--- a/pom.xml
+++ b/pom.xml
@@ -58,7 +58,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check japicmp:cmp
checkstyle:check pmd:cpd-check pmd:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check japicmp:cmp
checkstyle:check pmd:cpd-check pmd:check javadoc:javadoc
spotbugs:check</defaultGoal>
<pluginManagement>
<plugins>
<plugin>
diff --git a/src/conf/findbugs-exclude-filter.xml
b/src/conf/findbugs-exclude-filter.xml
index 6e79be57..48bf4ab7 100644
--- a/src/conf/findbugs-exclude-filter.xml
+++ b/src/conf/findbugs-exclude-filter.xml
@@ -26,4 +26,19 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0
https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd";>
+ <!-- TODO Can any of these be done without breaking binary compatibility? -->
+ <Match>
+ <Class name="~.*" />
+ <Or>
+ <Bug pattern="EI_EXPOSE_REP" />
+ <Bug pattern="EI_EXPOSE_REP2" />
+ </Or>
+ </Match>
+
+ <!-- https://github.com/spotbugs/spotbugs/issues/2710 -->
+ <Match>
+ <Class name="~.*" />
+ <Bug pattern="CT_CONSTRUCTOR_THROW" />
+ </Match>
+
</FindBugsFilter>
