This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 242a10d8 [IO-795] Finish TODO on CharSequenceInputStream (#540)
242a10d8 is described below

commit 242a10d85afeb1665f0909a9f77b9bacdd013aeb
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Wed Dec 27 17:02:40 2023 +0000

    [IO-795] Finish TODO on CharSequenceInputStream (#540)
    
    * [IO-795] finish TODO on CharSequenceInputStream and void default charset
    
    * restore TODO
---
 src/main/java/org/apache/commons/io/build/AbstractOrigin.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/io/build/AbstractOrigin.java 
b/src/main/java/org/apache/commons/io/build/AbstractOrigin.java
index 9268a325..dbeff9e1 100644
--- a/src/main/java/org/apache/commons/io/build/AbstractOrigin.java
+++ b/src/main/java/org/apache/commons/io/build/AbstractOrigin.java
@@ -39,6 +39,7 @@ import java.util.Objects;
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.io.RandomAccessFileMode;
 import org.apache.commons.io.RandomAccessFiles;
+import org.apache.commons.io.input.CharSequenceInputStream;
 import org.apache.commons.io.input.ReaderInputStream;
 import org.apache.commons.io.output.WriterOutputStream;
 
@@ -122,9 +123,7 @@ public abstract class AbstractOrigin<T, B extends 
AbstractOrigin<T, B>> extends
         @Override
         public InputStream getInputStream(final OpenOption... options) throws 
IOException {
             // TODO Pass in a Charset? Consider if call sites actually need 
this.
-            return new 
ByteArrayInputStream(origin.toString().getBytes(Charset.defaultCharset()));
-            // Needs [IO-795] CharSequenceInputStream.reset() only works once.
-            // return 
CharSequenceInputStream.builder().setCharSequence(getCharSequence(Charset.defaultCharset())).get();
+            return 
CharSequenceInputStream.builder().setCharSequence(getCharSequence(Charset.defaultCharset())).get();
         }
 
         @Override

Reply via email to