(commons-jci) branch master updated: Use constant instead of magic string

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jci.git


The following commit(s) were added to refs/heads/master by this push:
     new e54adaf  Use constant instead of magic string
e54adaf is described below

commit e54adaf5a1d494432981f94baca65c3e04995519
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Dec 10 11:04:16 2023 -0500

    Use constant instead of magic string
---
 .../jci2/compiler/eclipse/EclipseJavaCompilerSettingsTestCase.java    | 3 ++-
 .../org/apache/commons/jci2/core/compiler/JavaCompilerSettings.java   | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/compilers/eclipse/src/test/java/org/apache/commons/jci2/compiler/eclipse/EclipseJavaCompilerSettingsTestCase.java
 
b/compilers/eclipse/src/test/java/org/apache/commons/jci2/compiler/eclipse/EclipseJavaCompilerSettingsTestCase.java
index 966dd57..ef62d3a 100644
--- 
a/compilers/eclipse/src/test/java/org/apache/commons/jci2/compiler/eclipse/EclipseJavaCompilerSettingsTestCase.java
+++ 
b/compilers/eclipse/src/test/java/org/apache/commons/jci2/compiler/eclipse/EclipseJavaCompilerSettingsTestCase.java
@@ -17,6 +17,7 @@
 
 package org.apache.commons.jci2.compiler.eclipse;
 
+import java.nio.charset.StandardCharsets;
 import java.util.Map;
 
 import org.eclipse.jdt.internal.compiler.impl.CompilerOptions;
@@ -31,7 +32,7 @@ public final class EclipseJavaCompilerSettingsTestCase 
extends TestCase {
                assertEquals(CompilerOptions.DO_NOT_GENERATE, 
m.get(CompilerOptions.OPTION_ReportDeprecation));
                assertEquals(CompilerOptions.VERSION_1_4, 
m.get(CompilerOptions.OPTION_TargetPlatform));
                assertEquals(CompilerOptions.VERSION_1_4, 
m.get(CompilerOptions.OPTION_Source));
-               assertEquals("UTF-8", m.get(CompilerOptions.OPTION_Encoding));
+               assertEquals(StandardCharsets.UTF_8.name(), 
m.get(CompilerOptions.OPTION_Encoding));
        }
 
        public void testSourceVersion() {
diff --git 
a/core/src/main/java/org/apache/commons/jci2/core/compiler/JavaCompilerSettings.java
 
b/core/src/main/java/org/apache/commons/jci2/core/compiler/JavaCompilerSettings.java
index d93ac82..2da3f35 100644
--- 
a/core/src/main/java/org/apache/commons/jci2/core/compiler/JavaCompilerSettings.java
+++ 
b/core/src/main/java/org/apache/commons/jci2/core/compiler/JavaCompilerSettings.java
@@ -17,6 +17,8 @@
 
 package org.apache.commons.jci2.core.compiler;
 
+import java.nio.charset.StandardCharsets;
+
 /**
  * Most common denominator for JavaCompiler settings.
  *
@@ -30,7 +32,7 @@ public class JavaCompilerSettings {
 
     private String targetVersion = "1.4";
     private String sourceVersion = "1.4";
-    private String sourceEncoding = "UTF-8";
+    private String sourceEncoding = StandardCharsets.UTF_8.name();
     private boolean warnings;
     private boolean deprecations;
     private boolean debug;