This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jelly.git
The following commit(s) were added to refs/heads/master by this push: new 49f325bc Use String#isEmpty() 49f325bc is described below commit 49f325bc7dab03da12bc6469ca877116b79b4177 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Tue Nov 28 11:13:45 2023 -0500 Use String#isEmpty() --- .../fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java | 2 +- .../src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java | 2 +- .../src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java | 2 +- .../src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java | 2 +- .../src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java | 2 +- .../src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java | 2 +- .../src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java index bef155f2..991640f3 100644 --- a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java +++ b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java @@ -163,7 +163,7 @@ public class BundleTag extends TagSupport { LocalizationContext locCtxt = null; ResourceBundle bundle = null; - if ((basename == null) || basename.equals("")) { + if ((basename == null) || basename.isEmpty()) { return new LocalizationContext(); } diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java index b2d57b31..0640174d 100644 --- a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java +++ b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java @@ -163,7 +163,7 @@ public class FormatDateTag extends TagSupport { // Set time zone TimeZone tz = null; if ((etimeZone instanceof String) - && ((String) etimeZone).equals("")) { + && ((String) etimeZone).isEmpty()) { etimeZone = null; } if (etimeZone != null) { diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java index 4273aba8..cc1ede60 100644 --- a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java +++ b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java @@ -67,7 +67,7 @@ public class SetLocaleTag extends TagSupport { if (valueInput == null) { locale = Locale.getDefault(); } else if (valueInput instanceof String) { - if (((String) valueInput).trim().equals("")) { + if (((String) valueInput).trim().isEmpty()) { locale = Locale.getDefault(); } else { locale = parseLocale((String) valueInput, (String) variantInput); diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java index 4fec9485..6937a816 100644 --- a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java +++ b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java @@ -58,7 +58,7 @@ public class SetTimeZoneTag extends TagSupport { timeZone = TimeZone.getTimeZone("GMT"); } else if (valueInput instanceof String) { - if (((String) valueInput).trim().equals("")) { + if (((String) valueInput).trim().isEmpty()) { timeZone = TimeZone.getTimeZone("GMT"); } else { timeZone = TimeZone.getTimeZone((String) valueInput); diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java index 31d09dca..e30738dc 100644 --- a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java +++ b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java @@ -74,7 +74,7 @@ public class TimeZoneTag extends TagSupport { timeZone = TimeZone.getTimeZone("GMT"); } else if (valueInput instanceof String) { - if (((String) valueInput).trim().equals("")) { + if (((String) valueInput).trim().isEmpty()) { timeZone = TimeZone.getTimeZone("GMT"); } else { timeZone = TimeZone.getTimeZone((String) valueInput); diff --git a/jelly-tags/interaction/src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java b/jelly-tags/interaction/src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java index 484c9a64..42827683 100644 --- a/jelly-tags/interaction/src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java +++ b/jelly-tags/interaction/src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java @@ -187,7 +187,7 @@ public class AskTag extends TagSupport { // trim the input for tab completion input = input.trim(); - if (defaultInput != null && input.trim().equals("")) { + if (defaultInput != null && input.trim().isEmpty()) { input = defaultInput; } } else { diff --git a/jelly-tags/soap/src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java b/jelly-tags/soap/src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java index 0421f097..8758d51e 100644 --- a/jelly-tags/soap/src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java +++ b/jelly-tags/soap/src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java @@ -85,7 +85,7 @@ public class InvokeTag extends TagSupport { call.setTargetEndpointAddress(new java.net.URL(endpoint)); call.setOperationName(new QName(namespace, method)); - if ( userName != null && !userName.equals("") ) { + if ( userName != null && !userName.isEmpty() ) { call.setUsername( userName ); call.setPassword( password ); }