This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git

commit 8ef233a23b5b792991068d517f878dfa2392e93d
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Nov 28 10:58:40 2023 -0500

    Fix SpotBugs [ERROR] Medium: Class
    org.apache.commons.validator.routines.CreditCardValidator$1 defines
    non-transient non-serializable instance field ccr
    [org.apache.commons.validator.routines.CreditCardValidator$1] In
    CreditCardValidator.java SE_BAD_FIELD.
---
 src/changes/changes.xml                                                | 3 +++
 .../org/apache/commons/validator/routines/CreditCardValidator.java     | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 8e4bf620..669a92f3 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -84,6 +84,9 @@ The <action> type attribute can be add,update,fix,remove.
     <action type="fix" dev="ggregory" due-to="Gary Gregory">
       Precompile regular expression in 
InetAddressValidator.isValidInet6Address(String).
     </action>
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">
+      Fix SpotBugs [ERROR] Medium: Class 
org.apache.commons.validator.routines.CreditCardValidator$1 defines 
non-transient non-serializable instance field ccr 
[org.apache.commons.validator.routines.CreditCardValidator$1] In 
CreditCardValidator.java SE_BAD_FIELD.
+    </action>
     <!-- ADD -->
     <action type="add" dev="ggregory" due-to="Dependabot, Gary Gregory">
       Add github/codeql-action.
diff --git 
a/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java 
b/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
index 6bd345e5..6ab27aba 100644
--- 
a/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
+++ 
b/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
@@ -463,7 +463,7 @@ public class CreditCardValidator implements Serializable {
                 // must be numeric (rest of validation is done later)
                 new RegexValidator("(\\d+)") {
                     private static final long serialVersionUID = 1L;
-                    private final CreditCardRange[] ccr = 
creditCardRanges.clone();
+                    private final transient CreditCardRange[] ccr = 
creditCardRanges.clone();
                     @Override
                     // must return full string
                     public String validate(final String value) {

Reply via email to