This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 73bd30712453bbf245af8c2d05294def9bf3baf8
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Sat Nov 18 08:33:21 2023 +0000
Checkstyle: private final class should be declared as final
---
.../java/org/apache/commons/numbers/combinatorics/Stirling.java | 4 ++--
.../org/apache/commons/numbers/fraction/ContinuedFractionTest.java | 2 +-
.../commons/numbers/fraction/GeneralizedContinuedFractionTest.java | 6 +++---
.../src/main/java/org/apache/commons/numbers/quaternion/Slerp.java | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Stirling.java
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Stirling.java
index eb63797b..4415eafa 100644
---
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Stirling.java
+++
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Stirling.java
@@ -42,7 +42,7 @@ public final class Stirling {
* Precomputed Stirling numbers of the first kind.
* Provides a thread-safe lazy initialization of the cache.
*/
- private static class StirlingS1Cache {
+ private static final class StirlingS1Cache {
/** Maximum n to compute (exclusive).
* As s(21,3) = 13803759753640704000 is larger than Long.MAX_VALUE
* we must stop computation at row 21. */
@@ -70,7 +70,7 @@ public final class Stirling {
* Precomputed Stirling numbers of the second kind.
* Provides a thread-safe lazy initialization of the cache.
*/
- private static class StirlingS2Cache {
+ private static final class StirlingS2Cache {
/** Maximum n to compute (exclusive).
* As S(26,9) = 11201516780955125625 is larger than Long.MAX_VALUE
* we must stop computation at row 26. */
diff --git
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
index ac5db9cb..bc0d36a8 100644
---
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
+++
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
@@ -47,7 +47,7 @@ class ContinuedFractionTest {
* @see <a href="https://mathworld.wolfram.com/GoldenRatio.html";>MathWorld
Golden
* Ratio equation 17</a>
*/
- private static class GoldenRatio extends ContinuedFraction {
+ private static final class GoldenRatio extends ContinuedFraction {
private static final GoldenRatio INSTANCE = new GoldenRatio();
/**
diff --git
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/GeneralizedContinuedFractionTest.java
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/GeneralizedContinuedFractionTest.java
index ff22edf7..7eb68237 100644
---
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/GeneralizedContinuedFractionTest.java
+++
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/GeneralizedContinuedFractionTest.java
@@ -474,7 +474,7 @@ class GeneralizedContinuedFractionTest {
* 1 + ...
* </pre>
*/
- private static class GoldenRatio implements Supplier<Coefficient> {
+ private static final class GoldenRatio implements Supplier<Coefficient> {
private static final GoldenRatio INSTANCE = new GoldenRatio();
private static final Coefficient RESULT = Coefficient.of(1, 1);
@@ -499,7 +499,7 @@ class GeneralizedContinuedFractionTest {
* </pre>
* <p>The term 2 must be added to the generated series.
*/
- private static class E implements Supplier<Coefficient> {
+ private static final class E implements Supplier<Coefficient> {
private int n;
@Override
@@ -525,7 +525,7 @@ class GeneralizedContinuedFractionTest {
* 5 - ...
* </pre>
*/
- static class Tan implements Supplier<Coefficient> {
+ static final class Tan implements Supplier<Coefficient> {
private double a;
private double b = -1;
diff --git
a/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Slerp.java
b/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Slerp.java
index 95685288..6de55bd2 100644
---
a/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Slerp.java
+++
b/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Slerp.java
@@ -99,7 +99,7 @@ public class Slerp implements DoubleFunction<Quaternion> {
/**
* Linear interpolation, used when the quaternions are too closely aligned.
*/
- private class Linear implements DoubleFunction<Quaternion> {
+ private final class Linear implements DoubleFunction<Quaternion> {
/** {@inheritDoc} */
@Override
public Quaternion apply(double t) {
@@ -116,7 +116,7 @@ public class Slerp implements DoubleFunction<Quaternion> {
* When we may end up dividing by zero (cf. 1/sin(theta) term below).
* {@link Linear} interpolation must be used.
*/
- private class Spherical implements DoubleFunction<Quaternion> {
+ private final class Spherical implements DoubleFunction<Quaternion> {
/** Angle of rotation. */
private final double theta;
/** Sine of {@link #theta}. */
