This is an automated email from the ASF dual-hosted git repository.

henrib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git


The following commit(s) were added to refs/heads/master by this push:
     new fc3e19ad JEXL-410: reduced unnecessary public exposure;
fc3e19ad is described below

commit fc3e19ad1106696711d8ac95b137e44325a4cb52
Author: Henri Biestro <hbies...@cloudera.com>
AuthorDate: Mon Oct 23 11:05:22 2023 +0200

    JEXL-410: reduced unnecessary public exposure;
---
 src/test/java/org/apache/commons/jexl3/FeaturesTest.java | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/test/java/org/apache/commons/jexl3/FeaturesTest.java 
b/src/test/java/org/apache/commons/jexl3/FeaturesTest.java
index 1ab59642..c19a50fc 100644
--- a/src/test/java/org/apache/commons/jexl3/FeaturesTest.java
+++ b/src/test/java/org/apache/commons/jexl3/FeaturesTest.java
@@ -17,6 +17,7 @@
 package org.apache.commons.jexl3;
 
 import java.util.Arrays;
+import java.util.Collection;
 
 import org.junit.Assert;
 import org.junit.Test;
@@ -373,8 +374,8 @@ public class FeaturesTest extends JexlTestCase {
 
     @Test
     public void test410a() {
-        long x = JexlFeatures.ALL_FEATURES;
-        Assert.assertEquals(23, Long.bitCount(x));
+        long x = JexlFeatures.createAll().getFlags();
+        Assert.assertEquals(CONST_CAPTURE + 1, Long.bitCount(x));
         Assert.assertTrue((x & (1L << CONST_CAPTURE)) != 0);
 
         JexlFeatures all = JexlFeatures.createAll();
@@ -396,7 +397,8 @@ public class FeaturesTest extends JexlTestCase {
         Assert.assertFalse(features.supportsComparatorNames());
 
         final JexlEngine jexl = new JexlBuilder().features(features).create();
-        for(String varName : JexlFeatures.RESERVED_WORDS) {
+        Collection<String> reserved = features.getReservedNames();
+        for(String varName : reserved) {
             String src = "var " + varName;
             //JexlScript script = jexl.createScript(src);
             Assert.assertThrows(JexlException.Feature.class, () -> 
jexl.createScript(src));

Reply via email to