This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push:
new 74b4c868 Make private static classes final
74b4c868 is described below
commit 74b4c868a08c332f165a5ff3a06a4cd09f3de943
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Oct 11 09:35:33 2023 -0400
Make private static classes final
---
src/main/java/org/apache/commons/pool3/PoolUtils.java | 2 +-
.../org/apache/commons/pool3/impl/BaseGenericObjectPool.java | 2 +-
src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java | 6 +++---
.../org/apache/commons/pool3/impl/GenericKeyedObjectPool.java | 2 +-
.../apache/commons/pool3/impl/SecurityManagerCallStack.java | 4 ++--
.../java/org/apache/commons/pool3/impl/ThrowableCallStack.java | 2 +-
.../org/apache/commons/pool3/AbstractTestKeyedObjectPool.java | 2 +-
src/test/java/org/apache/commons/pool3/ObjectPoolIssue326.java | 6 +++---
src/test/java/org/apache/commons/pool3/PoolTest.java | 4 ++--
.../apache/commons/pool3/TestBaseKeyedPooledObjectFactory.java | 2 +-
src/test/java/org/apache/commons/pool3/TestBaseObjectPool.java | 2 +-
.../apache/commons/pool3/TestBasePoolableObjectFactory.java | 2 +-
.../commons/pool3/impl/TestAbandonedKeyedObjectPool.java | 2 +-
.../org/apache/commons/pool3/impl/TestAbandonedObjectPool.java | 2 +-
.../apache/commons/pool3/impl/TestGenericKeyedObjectPool.java | 10 +++++-----
.../org/apache/commons/pool3/impl/TestGenericObjectPool.java | 8 ++++----
.../commons/pool3/impl/TestGenericObjectPoolClassLoaders.java | 4 ++--
.../pool3/impl/TestGenericObjectPoolFactoryCreateFailure.java | 4 ++--
.../java/org/apache/commons/pool3/impl/TestPoolImplUtils.java | 4 ++--
.../org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java | 2 +-
.../apache/commons/pool3/impl/TestSoftReferenceObjectPool.java | 2 +-
.../pool3/impl/TestSynchronizedPooledObjectFactory.java | 2 +-
.../org/apache/commons/pool3/performance/PerformanceTest.java | 2 +-
.../org/apache/commons/pool3/pool407/KeyedPool407Test.java | 2 +-
.../java/org/apache/commons/pool3/pool407/Pool407Test.java | 2 +-
.../pool3/proxy/AbstractTestProxiedKeyedObjectPool.java | 4 ++--
.../commons/pool3/proxy/AbstractTestProxiedObjectPool.java | 4 ++--
27 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/src/main/java/org/apache/commons/pool3/PoolUtils.java
b/src/main/java/org/apache/commons/pool3/PoolUtils.java
index 17bf32f6..06d48034 100644
--- a/src/main/java/org/apache/commons/pool3/PoolUtils.java
+++ b/src/main/java/org/apache/commons/pool3/PoolUtils.java
@@ -332,7 +332,7 @@ public final class PoolUtils {
* @param <T> type of objects in the pool
* @param <E> type of exceptions from the pool
*/
- private static class ErodingObjectPool<T, E extends Exception> implements
ObjectPool<T, E> {
+ private static final class ErodingObjectPool<T, E extends Exception>
implements ObjectPool<T, E> {
/** Underlying object pool */
private final ObjectPool<T, E> pool;
diff --git
a/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
b/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
index a64d78a8..6a98f08a 100644
--- a/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
@@ -262,7 +262,7 @@ public abstract class BaseGenericObjectPool<T, E extends
Exception> extends Base
* Maintains a cache of values for a single metric and reports
* statistics on the cached values.
*/
- private static class StatsStore {
+ private static final class StatsStore {
private static final int NULL = -1;
private final AtomicLong[] values;
diff --git a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
index d45c366b..5be2c369 100644
--- a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
+++ b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
@@ -51,7 +51,7 @@ class EvictionTimer {
/**
* Thread factory that creates a daemon thread, with the context class
loader from this class.
*/
- private static class EvictorThreadFactory implements ThreadFactory {
+ private static final class EvictorThreadFactory implements ThreadFactory {
@Override
public Thread newThread(final Runnable runnable) {
@@ -70,7 +70,7 @@ class EvictionTimer {
* Task that removes references to abandoned tasks and shuts
* down the executor if there are no live tasks left.
*/
- private static class Reaper implements Runnable {
+ private static final class Reaper implements Runnable {
@Override
public void run() {
synchronized (EvictionTimer.class) {
@@ -95,7 +95,7 @@ class EvictionTimer {
* no longer reachable, run is no-op.
* @param <R> The kind of Runnable.
*/
- private static class WeakRunner<R extends Runnable> implements Runnable {
+ private static final class WeakRunner<R extends Runnable> implements
Runnable {
private final WeakReference<R> ref;
diff --git
a/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java
b/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java
index 1965d201..638fb080 100644
--- a/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java
+++ b/src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java
@@ -98,7 +98,7 @@ public class GenericKeyedObjectPool<K, T, E extends
Exception> extends BaseGener
*
* @param <S> type of objects in the pool
*/
- private static class ObjectDeque<S> {
+ private static final class ObjectDeque<S> {
private final LinkedBlockingDeque<PooledObject<S>> idleObjects;
diff --git
a/src/main/java/org/apache/commons/pool3/impl/SecurityManagerCallStack.java
b/src/main/java/org/apache/commons/pool3/impl/SecurityManagerCallStack.java
index 7c4af9a9..0a8da2b7 100644
--- a/src/main/java/org/apache/commons/pool3/impl/SecurityManagerCallStack.java
+++ b/src/main/java/org/apache/commons/pool3/impl/SecurityManagerCallStack.java
@@ -40,7 +40,7 @@ public class SecurityManagerCallStack implements CallStack {
/**
* A custom security manager.
*/
- private static class PrivateSecurityManager extends SecurityManager {
+ private static final class PrivateSecurityManager extends SecurityManager {
/**
* Gets the class stack.
@@ -56,7 +56,7 @@ public class SecurityManagerCallStack implements CallStack {
/**
* A snapshot of a class stack.
*/
- private static class Snapshot {
+ private static final class Snapshot {
private final long timestampMillis = System.currentTimeMillis();
private final List<WeakReference<Class<?>>> stack;
diff --git
a/src/main/java/org/apache/commons/pool3/impl/ThrowableCallStack.java
b/src/main/java/org/apache/commons/pool3/impl/ThrowableCallStack.java
index 304ea293..9e82cf50 100644
--- a/src/main/java/org/apache/commons/pool3/impl/ThrowableCallStack.java
+++ b/src/main/java/org/apache/commons/pool3/impl/ThrowableCallStack.java
@@ -33,7 +33,7 @@ public class ThrowableCallStack implements CallStack {
/**
* A snapshot of a throwable.
*/
- private static class Snapshot extends Throwable {
+ private static final class Snapshot extends Throwable {
private static final long serialVersionUID = 1L;
private final long timestampMillis = System.currentTimeMillis();
}
diff --git
a/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java
b/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java
index 797d1b1c..b83fbac6 100644
--- a/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/AbstractTestKeyedObjectPool.java
@@ -160,7 +160,7 @@ public abstract class AbstractTestKeyedObjectPool {
}
}
- private static class TestFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
+ private static final class TestFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
@Override
public Object create(final Object key) {
return new Object();
diff --git a/src/test/java/org/apache/commons/pool3/ObjectPoolIssue326.java
b/src/test/java/org/apache/commons/pool3/ObjectPoolIssue326.java
index 403516f1..7ce0f2f5 100644
--- a/src/test/java/org/apache/commons/pool3/ObjectPoolIssue326.java
+++ b/src/test/java/org/apache/commons/pool3/ObjectPoolIssue326.java
@@ -41,7 +41,7 @@ import
org.apache.commons.pool3.impl.GenericKeyedObjectPoolConfig;
* negatively since you need to run it for a while.
*/
public final class ObjectPoolIssue326 {
- private static class ObjectFactory extends
BaseKeyedPooledObjectFactory<Integer, Object, RuntimeException> {
+ private static final class ObjectFactory extends
BaseKeyedPooledObjectFactory<Integer, Object, RuntimeException> {
@Override
public Object create(final Integer s) {
return new TestObject();
@@ -53,7 +53,7 @@ public final class ObjectPoolIssue326 {
}
}
- private static class Task<E extends Exception> implements Callable<Object>
{
+ private static final class Task<E extends Exception> implements
Callable<Object> {
private final GenericKeyedObjectPool<Integer, Object, E> m_pool;
private final int m_key;
@@ -90,7 +90,7 @@ public final class ObjectPoolIssue326 {
}
}
- private static class TestObject {
+ private static final class TestObject {
}
public static void main(final String[] args) {
diff --git a/src/test/java/org/apache/commons/pool3/PoolTest.java
b/src/test/java/org/apache/commons/pool3/PoolTest.java
index 9a53d417..a090e28b 100644
--- a/src/test/java/org/apache/commons/pool3/PoolTest.java
+++ b/src/test/java/org/apache/commons/pool3/PoolTest.java
@@ -32,10 +32,10 @@ import org.junit.jupiter.api.Test;
@Disabled
public class PoolTest {
- private static class Foo {
+ private static final class Foo {
}
- private static class PooledFooFactory implements PooledObjectFactory<Foo,
RuntimeException> {
+ private static final class PooledFooFactory implements
PooledObjectFactory<Foo, RuntimeException> {
private static final long VALIDATION_WAIT_IN_MILLIS = 1000;
@Override
diff --git
a/src/test/java/org/apache/commons/pool3/TestBaseKeyedPooledObjectFactory.java
b/src/test/java/org/apache/commons/pool3/TestBaseKeyedPooledObjectFactory.java
index c2f1cdf6..a48e8a1b 100644
---
a/src/test/java/org/apache/commons/pool3/TestBaseKeyedPooledObjectFactory.java
+++
b/src/test/java/org/apache/commons/pool3/TestBaseKeyedPooledObjectFactory.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
*/
public class TestBaseKeyedPooledObjectFactory {
- private static class TestFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
+ private static final class TestFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
@Override
public Object create(final Object key) {
return null;
diff --git a/src/test/java/org/apache/commons/pool3/TestBaseObjectPool.java
b/src/test/java/org/apache/commons/pool3/TestBaseObjectPool.java
index a11e517e..a30a057f 100644
--- a/src/test/java/org/apache/commons/pool3/TestBaseObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/TestBaseObjectPool.java
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
*/
public class TestBaseObjectPool extends AbstractTestObjectPool {
- private static class TestObjectPool extends BaseObjectPool<Object,
RuntimeException> {
+ private static final class TestObjectPool extends BaseObjectPool<Object,
RuntimeException> {
@Override
public Object borrowObject() {
diff --git
a/src/test/java/org/apache/commons/pool3/TestBasePoolableObjectFactory.java
b/src/test/java/org/apache/commons/pool3/TestBasePoolableObjectFactory.java
index 7472994f..4cb15fcd 100644
--- a/src/test/java/org/apache/commons/pool3/TestBasePoolableObjectFactory.java
+++ b/src/test/java/org/apache/commons/pool3/TestBasePoolableObjectFactory.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
*/
public class TestBasePoolableObjectFactory {
- private static class TestFactory extends
BasePooledObjectFactory<AtomicInteger, RuntimeException> {
+ private static final class TestFactory extends
BasePooledObjectFactory<AtomicInteger, RuntimeException> {
@Override
public AtomicInteger create() {
return new AtomicInteger(0);
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
index 01690bac..712e1b38 100644
---
a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
+++
b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
@@ -78,7 +78,7 @@ public class TestAbandonedKeyedObjectPool {
}
}
- private static class SimpleFactory implements
KeyedPooledObjectFactory<Integer, PooledTestObject, InterruptedException> {
+ private static final class SimpleFactory implements
KeyedPooledObjectFactory<Integer, PooledTestObject, InterruptedException> {
private final long destroyLatencyMillis;
private final long validateLatencyMillis;
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
index fd3dbd65..471b814e 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
@@ -147,7 +147,7 @@ public class TestAbandonedObjectPool {
}
}
- private static class SimpleFactory implements
PooledObjectFactory<PooledTestObject, InterruptedException> {
+ private static final class SimpleFactory implements
PooledObjectFactory<PooledTestObject, InterruptedException> {
private final long destroyLatency;
private final long validateLatency;
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java
b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java
index 2c9b557c..7d8d0ecf 100644
---
a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java
+++
b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java
@@ -76,7 +76,7 @@ import org.junit.jupiter.params.provider.EnumSource;
*/
public class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool {
- private static class DaemonThreadFactory implements ThreadFactory {
+ private static final class DaemonThreadFactory implements ThreadFactory {
@Override
public Thread newThread(final Runnable r) {
final Thread t = new Thread(r);
@@ -85,7 +85,7 @@ public class TestGenericKeyedObjectPool extends
AbstractTestKeyedObjectPool {
}
}
- private static class DummyFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
+ private static final class DummyFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
@Override
public Object create(final Object key) {
return null;
@@ -147,7 +147,7 @@ public class TestGenericKeyedObjectPool extends
AbstractTestKeyedObjectPool {
}
}
- private static class ObjectFactory
+ private static final class ObjectFactory
extends BaseKeyedPooledObjectFactory<Integer, Object,
RuntimeException> {
@Override
@@ -294,7 +294,7 @@ public class TestGenericKeyedObjectPool extends
AbstractTestKeyedObjectPool {
}
}
- private static class SimplePerKeyFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
+ private static final class SimplePerKeyFactory extends
BaseKeyedPooledObjectFactory<Object, Object, RuntimeException> {
final ConcurrentHashMap<Object, AtomicInteger> map = new
ConcurrentHashMap<>();
@Override
@@ -335,7 +335,7 @@ public class TestGenericKeyedObjectPool extends
AbstractTestKeyedObjectPool {
/**
* DefaultEvictionPolicy modified to add latency
*/
- private static class SlowEvictionPolicy<T> extends
DefaultEvictionPolicy<T> {
+ private static final class SlowEvictionPolicy<T> extends
DefaultEvictionPolicy<T> {
private final long delay;
/**
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
index efb56e93..b052c749 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
@@ -95,7 +95,7 @@ public class TestGenericObjectPool extends TestBaseObjectPool
{
}
}
- private static class CreateErrorFactory extends
BasePooledObjectFactory<String, InterruptedException> {
+ private static final class CreateErrorFactory extends
BasePooledObjectFactory<String, InterruptedException> {
private final Semaphore semaphore = new Semaphore(0);
@@ -119,7 +119,7 @@ public class TestGenericObjectPool extends
TestBaseObjectPool {
}
}
- private static class CreateFailFactory extends
BasePooledObjectFactory<String, InterruptedException> {
+ private static final class CreateFailFactory extends
BasePooledObjectFactory<String, InterruptedException> {
private final Semaphore semaphore = new Semaphore(0);
@@ -155,7 +155,7 @@ public class TestGenericObjectPool extends
TestBaseObjectPool {
}
}
- private static class EvictionThread<T, E extends Exception> extends Thread
{
+ private static final class EvictionThread<T, E extends Exception> extends
Thread {
private final GenericObjectPool<T, E> pool;
@@ -218,7 +218,7 @@ public class TestGenericObjectPool extends
TestBaseObjectPool {
}
}
- private static class InvalidFactory
+ private static final class InvalidFactory
extends BasePooledObjectFactory<Object, RuntimeException> {
@Override
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolClassLoaders.java
b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolClassLoaders.java
index 05a9a401..54a3f9f0 100644
---
a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolClassLoaders.java
+++
b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolClassLoaders.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
public class TestGenericObjectPoolClassLoaders {
- private static class CustomClassLoader extends URLClassLoader {
+ private static final class CustomClassLoader extends URLClassLoader {
private final int n;
CustomClassLoader(final int n) {
@@ -46,7 +46,7 @@ public class TestGenericObjectPoolClassLoaders {
}
}
- private static class CustomClassLoaderObjectFactory extends
+ private static final class CustomClassLoaderObjectFactory extends
BasePooledObjectFactory<URL, IllegalStateException> {
private final int n;
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolFactoryCreateFailure.java
b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolFactoryCreateFailure.java
index 24e8b6c3..f40417b8 100644
---
a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolFactoryCreateFailure.java
+++
b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPoolFactoryCreateFailure.java
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Timeout;
*/
public class TestGenericObjectPoolFactoryCreateFailure {
- private static class SingleObjectFactory extends
BasePooledObjectFactory<Object, Exception> {
+ private static final class SingleObjectFactory extends
BasePooledObjectFactory<Object, Exception> {
private final AtomicBoolean created = new AtomicBoolean();
@Override
@@ -57,7 +57,7 @@ public class TestGenericObjectPoolFactoryCreateFailure {
}
}
- private static class WinnerRunnable implements Runnable {
+ private static final class WinnerRunnable implements Runnable {
private final CountDownLatch barrier;
private final AtomicBoolean failed;
private final GenericObjectPool<Object, Exception> pool;
diff --git a/src/test/java/org/apache/commons/pool3/impl/TestPoolImplUtils.java
b/src/test/java/org/apache/commons/pool3/impl/TestPoolImplUtils.java
index e5a19fcb..451e9486 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestPoolImplUtils.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestPoolImplUtils.java
@@ -51,7 +51,7 @@ public class TestPoolImplUtils {
// empty by design
}
- private static class NotSimpleFactory extends FactoryF<Integer> {
+ private static final class NotSimpleFactory extends FactoryF<Integer> {
@Override
public Long create() {
return null;
@@ -63,7 +63,7 @@ public class TestPoolImplUtils {
}
}
- private static class SimpleFactory extends BasePooledObjectFactory<String,
RuntimeException> {
+ private static final class SimpleFactory extends
BasePooledObjectFactory<String, RuntimeException> {
@Override
public String create() {
return null;
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java
b/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java
index ce625e60..8e0fd697 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestSoftRefOutOfMemory.java
@@ -56,7 +56,7 @@ public class TestSoftRefOutOfMemory {
}
}
- private static class OomeFactory extends BasePooledObjectFactory<String,
RuntimeException> {
+ private static final class OomeFactory extends
BasePooledObjectFactory<String, RuntimeException> {
private final OomeTrigger trigger;
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java
b/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java
index aa436ce2..0475bb14 100644
---
a/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java
+++
b/src/test/java/org/apache/commons/pool3/impl/TestSoftReferenceObjectPool.java
@@ -26,7 +26,7 @@ import org.apache.commons.pool3.TestBaseObjectPool;
*/
public class TestSoftReferenceObjectPool extends TestBaseObjectPool {
- private static class SimpleFactory extends BasePooledObjectFactory<String,
RuntimeException> {
+ private static final class SimpleFactory extends
BasePooledObjectFactory<String, RuntimeException> {
int counter;
diff --git
a/src/test/java/org/apache/commons/pool3/impl/TestSynchronizedPooledObjectFactory.java
b/src/test/java/org/apache/commons/pool3/impl/TestSynchronizedPooledObjectFactory.java
index 8e56b0ce..e104e221 100644
---
a/src/test/java/org/apache/commons/pool3/impl/TestSynchronizedPooledObjectFactory.java
+++
b/src/test/java/org/apache/commons/pool3/impl/TestSynchronizedPooledObjectFactory.java
@@ -24,7 +24,7 @@ import org.apache.commons.pool3.PooledObject;
import org.apache.commons.pool3.PooledObjectFactory;
/**
- * Copies PoolUtil's private static class SynchronizedPooledObjectFactory.
+ * Copies PoolUtil's private static final class
SynchronizedPooledObjectFactory.
*
* A fully synchronized PooledObjectFactory that wraps a PooledObjectFactory
and
* synchronizes access to the wrapped factory methods.
diff --git
a/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
b/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
index 94589ec9..b05bcc7f 100644
--- a/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
+++ b/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
@@ -91,7 +91,7 @@ public class PerformanceTest {
}
}
}
- private static class TaskStats {
+ private static final class TaskStats {
public int waiting;
public int complete;
public long totalBorrowNanos;
diff --git
a/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java
b/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java
index 2e5b3546..8e19ebae 100644
--- a/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java
+++ b/src/test/java/org/apache/commons/pool3/pool407/KeyedPool407Test.java
@@ -34,7 +34,7 @@ public class KeyedPool407Test extends AbstractPool407Test {
/**
* Borrows from a pool and then immediately returns to that a pool.
*/
- private static class KeyedPool407RoundtripRunnable implements Runnable {
+ private static final class KeyedPool407RoundtripRunnable implements
Runnable {
private final KeyedPool407 pool;
public KeyedPool407RoundtripRunnable(final KeyedPool407 pool) {
diff --git a/src/test/java/org/apache/commons/pool3/pool407/Pool407Test.java
b/src/test/java/org/apache/commons/pool3/pool407/Pool407Test.java
index 99bdb1d0..9dade557 100644
--- a/src/test/java/org/apache/commons/pool3/pool407/Pool407Test.java
+++ b/src/test/java/org/apache/commons/pool3/pool407/Pool407Test.java
@@ -34,7 +34,7 @@ public class Pool407Test extends AbstractPool407Test {
/**
* Borrows from a pool and then immediately returns to that a pool.
*/
- private static class Pool407RoundtripRunnable implements Runnable {
+ private static final class Pool407RoundtripRunnable implements Runnable {
private final Pool407 pool;
public Pool407RoundtripRunnable(final Pool407 pool) {
diff --git
a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java
b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java
index 462a1181..6bfc8d1d 100644
---
a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java
+++
b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedKeyedObjectPool.java
@@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test;
public abstract class AbstractTestProxiedKeyedObjectPool {
- private static class TestKeyedObjectFactory extends
BaseKeyedPooledObjectFactory<String, TestObject, RuntimeException> {
+ private static final class TestKeyedObjectFactory extends
BaseKeyedPooledObjectFactory<String, TestObject, RuntimeException> {
@Override
public TestObject create(final String key) {
@@ -58,7 +58,7 @@ public abstract class AbstractTestProxiedKeyedObjectPool {
void setData(String data);
}
- private static class TestObjectImpl implements TestObject {
+ private static final class TestObjectImpl implements TestObject {
private String data;
diff --git
a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java
b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java
index de818cff..f3985e96 100644
---
a/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java
+++
b/src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java
@@ -43,7 +43,7 @@ public abstract class AbstractTestProxiedObjectPool {
String getData();
void setData(String data);
}
- private static class TestObjectFactory extends
+ private static final class TestObjectFactory extends
BasePooledObjectFactory<TestObject, RuntimeException> {
@Override
@@ -56,7 +56,7 @@ public abstract class AbstractTestProxiedObjectPool {
}
}
- private static class TestObjectImpl implements TestObject {
+ private static final class TestObjectImpl implements TestObject {
private String data;
