This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git
The following commit(s) were added to refs/heads/master by this push:
new 1eb2a1fb Make private static classes final
1eb2a1fb is described below
commit 1eb2a1fbd6c77051f308ab0345781dc2e95e0e35
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Oct 10 16:40:00 2023 -0400
Make private static classes final
---
.../src/main/java/org/apache/commons/digester3/ObjectCreateRule.java | 4 ++--
.../src/main/java/org/apache/commons/digester3/RegexRules.java | 2 +-
.../src/test/java/org/apache/commons/digester3/DigesterTestCase.java | 2 +-
.../java/org/apache/commons/digester3/LocationTrackerTestCase.java | 2 +-
.../apache/commons/digester3/binder/BinderClassLoaderTestCase.java | 4 ++--
.../commons/digester3/substitution/CompoundSubstitutorTestCase.java | 2 +-
6 files changed, 8 insertions(+), 8 deletions(-)
diff --git
a/commons-digester3-core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
b/commons-digester3-core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
index e3fccd2a..da197a62 100644
---
a/commons-digester3-core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
+++
b/commons-digester3-core/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java
@@ -45,7 +45,7 @@ import org.xml.sax.SAXException;
public class ObjectCreateRule
extends Rule
{
- private static class DeferredConstructionCallback implements
MethodInterceptor
+ private static final class DeferredConstructionCallback implements
MethodInterceptor
{
Constructor<?> constructor;
Object[] constructorArgs;
@@ -89,7 +89,7 @@ public class ObjectCreateRule
}
}
- private static class ProxyManager
+ private static final class ProxyManager
{
private final Class<?> clazz;
private final Constructor<?> constructor;
diff --git
a/commons-digester3-core/src/main/java/org/apache/commons/digester3/RegexRules.java
b/commons-digester3-core/src/main/java/org/apache/commons/digester3/RegexRules.java
index b3c9705a..364c203f 100644
---
a/commons-digester3-core/src/main/java/org/apache/commons/digester3/RegexRules.java
+++
b/commons-digester3-core/src/main/java/org/apache/commons/digester3/RegexRules.java
@@ -146,7 +146,7 @@ public class RegexRules
}
/** Used to associate rules with paths in the rules list */
- private static class RegisteredRule
+ private static final class RegisteredRule
{
String pattern;
diff --git
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
index c12f0b9b..cf6199e9 100644
---
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
+++
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
@@ -605,7 +605,7 @@ public class DigesterTestCase
}
/** Utility class for method testStackAction */
- private static class TrackingStackAction
+ private static final class TrackingStackAction
implements StackAction
{
public ArrayList<String> events = new ArrayList<String>();
diff --git
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/LocationTrackerTestCase.java
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/LocationTrackerTestCase.java
index 44edd0a0..439366f7 100644
---
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/LocationTrackerTestCase.java
+++
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/LocationTrackerTestCase.java
@@ -39,7 +39,7 @@ import org.xml.sax.Locator;
public class LocationTrackerTestCase
{
- private static class LocationTracker
+ private static final class LocationTracker
implements StackAction
{
public Map<Object, String> locations = new HashMap<Object, String>();
diff --git
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
index a28ee83b..7c0fd0e2 100644
---
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
+++
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
@@ -207,7 +207,7 @@ public final class BinderClassLoaderTestCase
}
}
- private static class ExtendedClassLoader
+ private static final class ExtendedClassLoader
extends ClassLoader
{
@@ -248,7 +248,7 @@ public final class BinderClassLoaderTestCase
return super.getResource( name );
}
- private static class InMemoryURLStreamHandlerFactory
+ private static final class InMemoryURLStreamHandlerFactory
implements URLStreamHandlerFactory
{
@Override
diff --git
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
index 8f06d016..022664c2 100644
---
a/commons-digester3-core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
+++
b/commons-digester3-core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
@@ -33,7 +33,7 @@ public final class CompoundSubstitutorTestCase
{
- private static class SubstitutorStub
+ private static final class SubstitutorStub
extends Substitutor
{
