This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 45659e4e Make private static classes final
45659e4e is described below

commit 45659e4ee91bc42716a8452e36e4026f699d6b91
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Oct 10 16:07:05 2023 -0400

    Make private static classes final
---
 src/main/java/org/apache/commons/codec/digest/Blake3.java           | 6 +++---
 src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java   | 2 +-
 .../java/org/apache/commons/codec/digest/PureJavaCrc32Test.java     | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/digest/Blake3.java 
b/src/main/java/org/apache/commons/codec/digest/Blake3.java
index 72c8b302..e941c5bf 100644
--- a/src/main/java/org/apache/commons/codec/digest/Blake3.java
+++ b/src/main/java/org/apache/commons/codec/digest/Blake3.java
@@ -365,7 +365,7 @@ public final class Blake3 {
      * Represents the state just prior to either producing an eight word 
chaining value or any number of output bytes
      * when the ROOT flag is set.
      */
-    private static class Output {
+    private static final class Output {
         private final int[] inputChainingValue;
         private final int[] blockWords;
         private final long counter;
@@ -405,7 +405,7 @@ public final class Blake3 {
         }
     }
 
-    private static class ChunkState {
+    private static final class ChunkState {
         private int[] chainingValue;
         private final long chunkCounter;
         private final int flags;
@@ -458,7 +458,7 @@ public final class Blake3 {
         }
     }
 
-    private static class EngineState {
+    private static final class EngineState {
         private final int[] key;
         private final int flags;
         // Space for 54 subtree chaining values: 2^54 * CHUNK_LEN = 2^64
diff --git a/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java 
b/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java
index 7f6ed1f3..829bdd12 100644
--- a/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java
+++ b/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java
@@ -379,7 +379,7 @@ public class BaseNCodecTest {
      * Extend BaseNCodec without implementation (no operations = NoOp).
      * Used for testing the memory allocation in {@link 
BaseNCodec#ensureBufferSize(int, Context)}.
      */
-    private static class NoOpBaseNCodec extends BaseNCodec {
+    private static final class NoOpBaseNCodec extends BaseNCodec {
         NoOpBaseNCodec() {
             super(0, 0, 0, 0);
         }
diff --git 
a/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java 
b/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java
index 64765271..52466ff6 100644
--- a/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java
+++ b/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java
@@ -362,7 +362,7 @@ public class PureJavaCrc32Test {
       return new BenchResult(expected, sum/results.length);
     }
 
-    private static class BenchResult {
+    private static final class BenchResult {
       /** CRC value */
       final long value;
       /** Speed (MB per second) */

Reply via email to