This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch release in repository https://gitbox.apache.org/repos/asf/commons-net.git
from 2b95bc2a Fix subsection title add d88de866 Fix release date add 884c0959 Remove old broken links add deeb30e7 Add security page add 78968eb3 Fix subsection title add 80303a57 Undo Bump actions/setup-java from 3.6.0 to 3.7.0 add 5dbf9473 Bump ossf/scorecard-action from 2.0.6 to 2.1.0 add 097dd4bd Merge pull request #131 from apache/dependabot/github_actions/ossf/scorecard-action-2.1.0 add a47cc7f5 Bump actions/checkout from 3.1.0 to 3.2.0 add 359096f2 Merge pull request #129 from apache/dependabot/github_actions/actions/checkout-3.2.0 add 7278391d Bump actions/setup-java from 3.6.0 to 3.9.0 add 914ea4e2 Merge pull request #130 from apache/dependabot/github_actions/actions/setup-java-3.9.0 add 3c229d93 Bump commons-parent from 54 to 55 add 555f4813 Merge pull request #132 from apache/dependabot/maven/org.apache.commons-commons-parent-55 add 6d047633 Bump commons-parent from 54 to 55 #132 add 44e38922 Bump ossf/scorecard-action from 2.1.0 to 2.1.2 add 98c11df1 Merge pull request #133 from apache/dependabot/github_actions/ossf/scorecard-action-2.1.2 add 71a64451 Bump actions/cache from 3.0.11 to 3.2.0 add b690756c Merge pull request #134 from apache/dependabot/github_actions/actions/cache-3.2.0 add 690c3453 Bump actions/cache from 3.2.0 to 3.2.2 add d2054108 Merge pull request #135 from apache/dependabot/github_actions/actions/cache-3.2.2 add a33d979a Update NOTICE to 2023 add 3a9c15e5 Bump actions/checkout from 3.2.0 to 3.3.0 add 0a3448e8 Merge pull request #136 from apache/dependabot/github_actions/actions/checkout-3.3.0 add 803e4699 Bump commons-parent from 55 to 56 add 5ed3ca68 Merge pull request #137 from apache/dependabot/maven/org.apache.commons-commons-parent-56 add 3805346f Bump commons-parent from 55 to 56 #137 add c479c05a NET-650 Delegated host resolution to Socket.connect() add 69ca4295 Merge pull request #138 from exceptionfactory/NET-650 add ebf65188 [NET-650] Delegate host resolution to Socket.connect() #138 add 78967ea6 [NET-650] Delegate host resolution to Socket.connect() add bcb45fa7 Javadoc add a140c77d Pick up JUnit version from parent POM add 5b3654a7 Pick up JUnit version from parent POM add f8340934 Pick up JaCoCo version from parent POM add 6dde7457 Pick up maven-surefire-plugin version from parent POM add a409075a Bump actions/cache from 3.2.2 to 3.2.3 add a736b998 Merge pull request #139 from apache/dependabot/github_actions/actions/cache-3.2.3 add 52069e23 Bump actions/upload-artifact from 3.1.1 to 3.1.2 add f897e542 Merge pull request #140 from apache/dependabot/github_actions/actions/upload-artifact-3.1.2 add c9647d26 Fix typos add c5c136ce POM project name should contain "Apache" prefix add 77030e6d fixes grammar issues in JavaDoc and code comments. fixes several typos found along the way. addresses PR reviewers' comments. add f9ff6c31 Merge pull request #141 from mawiesne/Fixes_grammar_issues_and_typos_in_JavaDoc_and_comments add c65261bf Fixes many grammar issues and typos in JavaDoc and code comments #141. add 9ef06b74 Update dependabot notifications add d6ec4269 Bump actions/cache from 3.2.3 to 3.2.4 add 9e27977d Merge pull request #142 from apache/dependabot/github_actions/actions/cache-3.2.4 add 1138f3a4 Pick up Checkstyle version from parent POM add 3928f012 codecov-commenter => notifications add 94197549 Bump actions/setup-java from 3.9.0 to 3.10.0 add 48822a9c Merge pull request #143 from apache/dependabot/github_actions/actions/setup-java-3.10.0 add e8e311d8 Bump actions/cache from 3.2.4 to 3.2.5 add eb6c36ff Merge pull request #144 from apache/dependabot/github_actions/actions/cache-3.2.5 add 00fca4f0 Bump actions/cache from 3.2.5 to 3.2.6 add 1ad6fde6 Merge pull request #145 from apache/dependabot/github_actions/actions/cache-3.2.6 add 55f1dd65 Bump actions/cache from 3.2.6 to 3.3.0 add 04f0bd2e Merge pull request #146 from apache/dependabot/github_actions/actions/cache-3.3.0 add 3bbd7f66 Add SNAPSHOT suffix to development version add a6e87592 Use XSD add 099dd932 Bump actions/cache from 3.3.0 to 3.3.1 add d633f187 Merge pull request #147 from apache/dependabot/github_actions/actions/cache-3.3.1 add 51c04172 Bump actions/checkout from 3.3.0 to 3.4.0 add fe82d301 Merge pull request #148 from apache/dependabot/github_actions/actions/checkout-3.4.0 add 5e8f565b Javadoc/Comments: Remove extra "whitespace" add 9e2bbe23 Javadoc: Remove extra "whitespace" add 45ebb3c2 Fix URL add b09f0af3 Bump actions/checkout from 3.4.0 to 3.5.0 add 36f93479 Merge pull request #151 from apache/dependabot/github_actions/actions/checkout-3.5.0 add 1f832bee Bump actions/setup-java from 3.10.0 to 3.11.0 add e7137611 Merge pull request #149 from apache/dependabot/github_actions/actions/setup-java-3.11.0 add 07e8df4a Bump ossf/scorecard-action from 2.1.2 to 2.1.3 add 283ed812 Merge pull request #150 from apache/dependabot/github_actions/ossf/scorecard-action-2.1.3 add fddd127d Bump actions/checkout from 3.5.0 to 3.5.2 add 9b9466a8 Merge pull request #152 from apache/dependabot/github_actions/actions/checkout-3.5.2 add 877fc65c Format: "catch(" -> "catch (" add 1c639134 Javadoc: Use {@code } instead of HTML tags. add 71cae370 Bump commons-parent from 56 to 57 add 907f292b Merge pull request #153 from apache/dependabot/maven/org.apache.commons-commons-parent-57 add f6d42be4 Bump commons-parent from 56 to 57 #153 add a140f371 Bump commons-io from 2.11.0 to 2.12.0. add 28c0ed79 Javadoc typos add 56e84eaf Grammar add 3f0efcff Bump commons-parent from 57 to 58 add 39ba0655 Bump commons-io from 2.12.0 to 2.13.0 add 5a068652 Bump actions/checkout from 3.5.2 to 3.5.3 add 2df2fe6b Merge pull request #156 from apache/dependabot/github_actions/actions/checkout-3.5.3 add 74eb3b31 removes redundant / non-required (null) initializations removes non-required return statements in void methods improves "text-only" URLs in JavaDoc fixes some typos and unpaired brackets along the path add d0baac63 Javadoc: Close HTML tag and end sentence with a period add 5e6ad6d6 Merge pull request #155 from mawiesne/remove_non-required_null_initializations add 101b926a Remove redundant (null) initializations and other clean ups #155 add 93f6f8dc End sentence with a period add abce343a Javadoc add b6cb0868 Remove underscores from instance variable names add 4db07099 Add and use Duration-based timeout method instead of int add 56418707 Organize imports add eebb82e9 Use diamond notation add fc090251 Remove trailing whitespace add 00aa2baf Add and use Duration-based timeout method instead of int add 496d6b94 Remove underscores from instance variable names add 62293ea5 Format tweak. add 161813f8 Javadoc add ba6a779d TFTPServer setter methods now throws IllegalArgumentException instead of RuntimeException add 0ec9f709 TFTPServer setter methods now throws IllegalArgumentException instead of RuntimeException add dc521529 Format tweaks add 5c3f9bd6 FTPCommand.checkArray() now throws IllegalStateException instead of RuntimeException. add dd6e8cd6 NntpThreadContainer.flush() now throws IllegalStateException instead of RuntimeException. add abaa661e org.apache.commons.net.nntp.Threader now throws IllegalStateException instead of RuntimeException. add 672cdd46 POP3Command static initializer now throws IllegalStateException instead of RuntimeException. add 1bb0eb61 FTPClientTest now throws IllegalStateException instead of RuntimeException. add 51d1f869 SMTPCommand static initializer now throws IllegalStateException instead of RuntimeException. add 5277c76d SubnetUtils.SubnetInfo.getPreviousAddress() now throws IllegalStateException instead of RuntimeException. add c6b66581 Format tweak add 7cc306f2 Clean up exception handling in example add fcf294f4 Javadoc add c6ba3526 Javadoc add 68c20046 IMAPExportMbox.MboxListener.chunkReceived(IMAP) now throws UncheckedIOException instead of RuntimeException. add f4839f86 IMAPUtils.imapLogin(URI, int, ProtocolCommandListener) now throws IOException instead of RuntimeException while maintaining method signature source compatibility add 5586d0d3 Clean up exception handling in example add 3502a3b0 Add and use DatagramSocketClient#getSoTimeoutDuration(). add fd4fc19d Don't reinitialize to default values add a6816444 Add and use DatagramSocketClient.checkOpen() add 3d75d6fe Javadoc add 252832a6 Better name add d817fef6 Better name add 83d1d9ff Better name add 582ee31c Better name add 92a80e47 Use Boolean.getBoolean() add 74203afe [StepSecurity] ci: Harden GitHub Actions add 2ec20021 Merge pull request #158 from step-security-bot/stepsecurity_remediation_1687640653 add 1fcc3d03 [StepSecurity] ci: Harden GitHub Actions #156 add 8198c661 Add TelnetClient.sendAYT(Duration). add 355f4f20 Declare and initialize local variables at the same time add 67932a7e [NET-722] Javadoc for FtpClient.setControlKeepAliveReplyTimeout(Duration) says timeout is in milliseconds add aa906c5c Bump ossf/scorecard-action from 2.1.3 to 2.2.0 add 53bd8228 Merge pull request #159 from apache/dependabot/github_actions/ossf/scorecard-action-2.2.0 add 04c12a39 Bump github/codeql-action from 2.1.22 to 2.20.1 add 83e17b15 Merge pull request #160 from apache/dependabot/github_actions/github/codeql-action-2.20.1 add 1f18a03a Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-net.git add 5d134406 [NET-722] Javadoc for FtpClient.setControlKeepAliveReplyTimeout(Duration) says timeout is in milliseconds add 967fdb18 Update Base64 documentation to reflect code, fix some typos add 8349a596 Add missing tests for base64 decoding and encoding add 7c11889a Add missing @code tag for docs add 458b2be8 Merge pull request #161 from jkbkupczyk/base_64_tests_and_doc_typos add dd0ae5d5 Add Base64 missing tests and documentation fixes #161 add 6ac0f5ad Fixes typos, adjusts docs to code, adds missing javadoc code snippets add 97755cfe Add FTPFile tests add ad158072 Make toString tests public add 5fb7bcea CR: move serialization methods to origin add e1dafc38 Remove blank Javadoc line between tags add bb4e29aa Add link to Javadoc toString method, remove blank Javadoc line between tags add 6bb6b028 Add licensing ti test add 6a07ceb4 Add TODO add c87fb922 Merge pull request #162 from jkbkupczyk/ftp_file_tests_and_doc_typos add 38a1b968 Add FTPFile tests and fix Javadoc typos #162. add e9435c92 Bump github/codeql-action from 2.20.1 to 2.20.3 add 53ce103a Merge pull request #163 from apache/dependabot/github_actions/github/codeql-action-2.20.3 add 7dce4d54 Migrate SubnetUtilsTest to JUnit5, replace try-catch with assertThrows add b6a47007 Merge pull request #164 from jkbkupczyk/subnet_utils_junit5 add 876d6976 Use a JRE built-in Charset instead of a magic string add 73f19514 Fix typos in AuthenticatingIMAPClient::AUTH_METHOD Javadoc add 7277fe0a Remove unnecessary newline, fix Javadoc typo add 816c0f48 Migrate IMAPTest to Junit5 add 68a1404b Add IMAPReply tests add 0ef492bd TFTPServer implements AutoCloseable add e46e9758 Port test from JUnit 3 to 5 add 607e32ec Let tests close TFTPClient add fb35673b Javadoc add 245c3de9 Javadoc add 21eba7bf Better local names add 62333495 Use try-with-resources add 02c69d05 DatagramSocketClient implements AutoCloseable add aefe84f0 Typos add 9a849002 Don't use deprecated API internally add f69967ab Move error outside the input stream try block add bca3ac87 Javadoc add 7875a563 Use final add 0638ce84 Javadoc add df506cfc Normalize names add cc289cc4 Comment add 4c13fd4d Better test failure message add 0f666037 Bulletproof bills add 5dd8f927 Bulletproof bills add ae1dad6c Add @Override add 4123523f Remove private method add 4213170b Typos add bcd77d46 Use try-with-resources add c1381bb7 Bulletproof tests add 17d45358 Normalize names in tests add 75da8c2d Reuse FileUtils in tests add c1e77b1b Normalize internal names add 71e1728d Merge branch 'apache:master' into add_imap_reply_tests_refactor_imap_test add 553d10e4 Merge pull request #165 from jkbkupczyk/add_imap_reply_tests_refactor_imap_test add 80d3d14c Add IMAPReply tests and documentation fixes #165 add 27d2eed0 Bump github/codeql-action from 2.20.3 to 2.21.0 add 541c7d6f Merge pull request #167 from apache/dependabot/github_actions/github/codeql-action-2.21.0 add f7ec7c7b Normalize spelling add 9c7a0aa6 Add junit-jupiter-params dependency add 00e4b261 Refactor IMAPReplyTest to use parameterized tests, add negative test case add e8f1c5cd IMAPCommand formatting + add Javadoc tags add 4c17aaca Add tests for AuthenticatingIMAPClientTest::AUTH_METHOD add 795d84bc Add IMAPCommandTest tests add 68fc62b4 Add IMAP tests, add @Disabled cause add c164a119 CR Javadoc add ccaf219a Remove boilerplate noise add d87e5038 Remove boilerplate noise add 577f4120 Merge pull request #166 from jkbkupczyk/imap_package_tests_add_params add 72bf4127 Add IMAP package tests, include junit-jupiter-params artifact #166. add 6b95f98a Move some entries add 21ec85ab Organize imports add b3293e67 Sort members add 034a27ee Use compact array initialization add 9d9cb30e Bump github/codeql-action from 2.21.0 to 2.21.1 add 743e3271 Merge pull request #169 from apache/dependabot/github_actions/github/codeql-action-2.21.1 add cc403d4d Bump actions/setup-java from 3.11.0 to 3.12.0 add f6814642 Merge pull request #170 from apache/dependabot/github_actions/actions/setup-java-3.12.0 add 74b6c28c Bump commons-parent from 58 to 59 add be43bb71 Bump commons-lang3 from 3.12.0 to 3.13.0 add 9316f257 Bump github/codeql-action from 2.21.1 to 2.21.2 add d6d5c226 Merge pull request #171 from apache/dependabot/github_actions/github/codeql-action-2.21.2 add e31e13ca Bump github/codeql-action from 2.21.2 to 2.21.3 add dd89dafb Merge pull request #172 from apache/dependabot/github_actions/github/codeql-action-2.21.3 add 26c5bce4 Add TFTPServer::getPort method add 2afbae2f Bulletproof TFTPServerPathTest add 2d0e6ece Add test to verify written content add 8c824291 Bump github/codeql-action from 2.21.3 to 2.21.4 add 566b6c76 Merge pull request #174 from apache/dependabot/github_actions/github/codeql-action-2.21.4 add ee902fce Better internal class name add d47c87e7 Fix formatting add d97a9399 Inline single use local variable add 0f17b108 Use assertThrows add 5c871fea Use assertThrows add 8a2999ed Normalize array type declarations add 80638cd4 Use `assertThrows` in test add 2b56e229 Merge pull request #175 from basil/assertThrows add b73016d0 Bump actions/checkout from 3.5.3 to 3.6.0 add bbfae2dc Merge pull request #177 from apache/dependabot/github_actions/actions/checkout-3.6.0 add fa4c5d40 Bump commons-parent from 59 to 61 add 2d335ac9 Bump github/codeql-action from 2.21.4 to 2.21.5 add 4d226570 Merge pull request #178 from apache/dependabot/github_actions/github/codeql-action-2.21.5 add 1d22800f Update DTD add ae1d8a78 Bump commons-parent from 61 to 62 add da45f3e5 Bump actions/cache from 3.3.1 to 3.3.2 add 1dcef8e5 Merge pull request #179 from apache/dependabot/github_actions/actions/cache-3.3.2 add a281c69c Bump actions/upload-artifact from 3.1.2 to 3.1.3 add b031522c Merge pull request #180 from apache/dependabot/github_actions/actions/upload-artifact-3.1.3 add 2344f5d6 Bump actions/checkout from 3.6.0 to 4.0.0 add ae34ff84 Merge pull request #181 from apache/dependabot/github_actions/actions/checkout-4.0.0 add b6f858a0 Add files via upload add 0d35962b ARCIVE instead of ARCHIVE is correct add b582aa23 Add additional ftp return strings add 4fc77b5f Update Javadoc link add c5efbb49 Fix Jaavdoc warnings add b664572a Fix Jaavdoc warnings add ae1e7116 Fix Jaavdoc warnings add 8137d9da Fix Jaavdoc warnings add ce3449b4 Fix Jaavdoc warnings add 4063b37a Fix Jaavdoc warnings add f8a6cde1 Normalize Javadoc add 0c721b99 Fix Jaavdoc warnings add 4cfed14f Fix Javadoc warnings add 8c15d2d6 Fix Javadoc warnings add 10932e92 Fix Javadoc warnings add 48451641 Fix Javadoc warnings add e62a020f Fix Javadoc warnings add 82fac6ca Merge branch 'apache:master' into Fixing-of-MVSFTPEntryParser add d8358120 Fix coding errors (e.g. missing "{}" after if) add c4003ffa Fix coding errors (e.g. missing "{}" after if) add f8e38505 fix code indentation add 0d7c9cc1 Merge pull request #182 from haegar9766/Fixing-of-MVSFTPEntryParser add 21349623 Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets #182 add 9e2dee88 Refactor commons private code add fbb4bcae Better param name add 67fcb7d1 Remove noisy parens add 529d45b1 Remove noisy parens and trailing whitespace add 04817c96 Simplify add 4d656cd6 Bump github/codeql-action from 2.21.5 to 2.21.7 add b77cc287 Merge pull request #183 from apache/dependabot/github_actions/github/codeql-action-2.21.7 add 5e137c62 Partial patch: Bulletproof TFTPServerPathTest #173 from Jakub Kupczyk add cd0aa017 Reuse FileUtils#contentEquals(File,File) in tests add e3013d78 Merge branch 'master' into fix_ci_failing_tests add 3750563c Merge pull request #173 from jkbkupczyk/fix_ci_failing_tests add d8fcdc71 Bulletproof TFTPServerPathTest #173. add 048d8a87 Resolve a FileName to correct FileType #424 add d47b3c46 Wrong component add 4074c2ec Bulletproof TFTPServerPathTest #173. add 9f524a11 Use random file name in TFTPServerPathTest add 219e1e31 Merge pull request #184 from jkbkupczyk/fix_broken_builds_173 add 642c4d22 Remove console output in tests add d94c3007 Deprecate org.apache.commons.net.util.Base64 in favor of java.util.Base64 add 396bade2 Replace use of org.apache.commons.net.util.Base64 with java.util.Base64 in org.apache.commons.net.ftp add e644e559 Replace use of org.apache.commons.net.util.Base64 with java.util.Base64 in org.apache.commons.net.imap add 15e58bbf Replace use of org.apache.commons.net.util.Base64 with java.util.Base64 in org.apache.commons.net.pop3 add 88e36500 Replace use of org.apache.commons.net.util.Base64 with java.util.Base64 in org.apache.commons.net.smtp add 823add4a Sort members add 23d8fc85 Be more lenient add e3ee2643 Be more lenient add 2ab9f5eb Remove trailing whitespace add 5fac3d96 Declutter root folder from Checkstyle add 1717554a Javadoc add 099f535c Declutter root folder from Spotbugs add b39b16de Remove old info add abcfc653 Refactor magic strings into private constants add d8cceba3 Normalize spelling add 52eca282 Javadoc add 3cf559ee Javadoc add 909847c9 Use try-with-resources add 4d72dac7 Use try-with-resources add 5bb7ca6a Javadoc add 7d708664 Javadoc add 7d58933e Javadoc add c3aa22c8 Javadoc add 516f75fa Javadoc add 10ae0af1 Javadoc: Fix "warning: empty <p> tag" add 144a82c3 Use Objects.toString() add 3bb2db3c Javadoc: Fix "warning: empty <p> tag" add 394430d0 Bump actions/setup-java from 3.12.0 to 3.13.0 add 4e98098c Merge pull request #186 from apache/dependabot/github_actions/actions/setup-java-3.13.0 add 8b184d75 Bump github/codeql-action from 2.21.7 to 2.21.8 add 74a43e40 Merge pull request #185 from apache/dependabot/github_actions/github/codeql-action-2.21.8 add 00134af2 Bump actions/checkout from 4.0.0 to 4.1.0 add 63974a63 Merge pull request #188 from apache/dependabot/github_actions/actions/checkout-4.1.0 add ab31ad8d Bump github/codeql-action from 2.21.8 to 2.21.9 add 64ff4e09 Merge pull request #187 from apache/dependabot/github_actions/github/codeql-action-2.21.9 add 092d1d80 Bump commons-io from 2.13.0 to 2.14.0 add 26fbd9ed Prepare for release candidate new e260e836 Merge branch 'master' into release The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .asf.yaml | 4 + .github/workflows/codeql-analysis.yml | 10 +- .github/workflows/coverage.yml | 8 +- .github/workflows/maven.yml | 6 +- .github/workflows/maven_adhoc.yml | 4 +- .github/workflows/scorecards-analysis.yml | 8 +- BUILDING.txt | 29 +- NOTICE.txt | 2 +- README.md | 14 +- RELEASE-NOTES.txt | 81 ++++- pom.xml | 43 +-- src/changes/changes.xml | 137 ++++++-- src/changes/release-notes.vm | 4 +- .../conf/checkstyle-suppressions.xml | 0 checkstyle.xml => src/conf/checkstyle.xml | 4 +- .../conf/findbugs-exclude-filter.xml | 0 .../apache/commons/net/DatagramSocketClient.java | 92 ++++-- .../apache/commons/net/DatagramSocketFactory.java | 6 +- .../commons/net/DefaultDatagramSocketFactory.java | 11 +- .../commons/net/MalformedServerReplyException.java | 2 - .../apache/commons/net/PrintCommandListener.java | 2 +- .../apache/commons/net/ProtocolCommandEvent.java | 2 +- .../java/org/apache/commons/net/SocketClient.java | 39 ++- .../org/apache/commons/net/bsd/RCommandClient.java | 71 ++--- .../org/apache/commons/net/bsd/RExecClient.java | 22 +- .../org/apache/commons/net/bsd/RLoginClient.java | 10 +- .../commons/net/chargen/CharGenTCPClient.java | 2 +- .../commons/net/chargen/CharGenUDPClient.java | 8 +- .../commons/net/daytime/DaytimeUDPClient.java | 4 +- .../commons/net/discard/DiscardUDPClient.java | 2 +- .../org/apache/commons/net/echo/EchoUDPClient.java | 2 +- .../java/org/apache/commons/net/examples/Main.java | 1 - .../net/examples/cidr/SubnetUtilsExample.java | 1 - .../commons/net/examples/ftp/FTPClientExample.java | 26 +- .../net/examples/ftp/ServerToServerFTP.java | 14 +- .../commons/net/examples/ftp/TFTPExample.java | 35 +- .../commons/net/examples/mail/IMAPExportMbox.java | 11 +- .../commons/net/examples/mail/IMAPImportMbox.java | 4 +- .../apache/commons/net/examples/mail/IMAPMail.java | 11 +- .../commons/net/examples/mail/IMAPUtils.java | 19 +- .../commons/net/examples/mail/POP3ExportMbox.java | 15 +- .../apache/commons/net/examples/mail/POP3Mail.java | 5 +- .../apache/commons/net/examples/mail/Utils.java | 4 +- .../commons/net/examples/nntp/ExtendedNNTPOps.java | 2 +- .../net/examples/nntp/MessageThreading.java | 2 +- .../apache/commons/net/examples/ntp/NTPClient.java | 3 +- .../commons/net/examples/ntp/SimpleNTPServer.java | 2 +- .../commons/net/examples/ntp/TimeClient.java | 3 +- .../net/examples/telnet/TelnetClientExample.java | 7 +- .../apache/commons/net/examples/unix/chargen.java | 54 ++-- .../apache/commons/net/examples/unix/daytime.java | 13 +- .../org/apache/commons/net/examples/unix/echo.java | 103 +++--- .../apache/commons/net/examples/unix/rdate.java | 14 +- .../apache/commons/net/examples/unix/rexec.java | 22 +- .../apache/commons/net/examples/unix/rlogin.java | 26 +- .../apache/commons/net/examples/unix/rshell.java | 16 +- .../apache/commons/net/finger/FingerClient.java | 19 +- src/main/java/org/apache/commons/net/ftp/FTP.java | 30 +- .../java/org/apache/commons/net/ftp/FTPClient.java | 95 +++--- .../apache/commons/net/ftp/FTPClientConfig.java | 26 +- .../java/org/apache/commons/net/ftp/FTPCmd.java | 193 ++++++++++- .../org/apache/commons/net/ftp/FTPCommand.java | 202 +++++++++++- .../java/org/apache/commons/net/ftp/FTPFile.java | 48 +-- .../apache/commons/net/ftp/FTPFileEntryParser.java | 6 +- .../commons/net/ftp/FTPFileEntryParserImpl.java | 1 - .../org/apache/commons/net/ftp/FTPFileFilter.java | 1 - .../org/apache/commons/net/ftp/FTPFileFilters.java | 1 - .../org/apache/commons/net/ftp/FTPHTTPClient.java | 15 +- .../apache/commons/net/ftp/FTPListParseEngine.java | 14 +- .../java/org/apache/commons/net/ftp/FTPReply.java | 184 +++++++++-- .../org/apache/commons/net/ftp/FTPSClient.java | 50 ++- .../net/ftp/parser/CompositeFileEntryParser.java | 4 +- .../parser/DefaultFTPFileEntryParserFactory.java | 2 +- .../ftp/parser/EnterpriseUnixFTPEntryParser.java | 2 +- .../net/ftp/parser/FTPFileEntryParserFactory.java | 2 +- .../net/ftp/parser/FTPTimestampParserImpl.java | 10 +- .../commons/net/ftp/parser/MLSxEntryParser.java | 2 +- .../commons/net/ftp/parser/MVSFTPEntryParser.java | 89 +++--- .../net/ftp/parser/MacOsPeterFTPEntryParser.java | 10 +- .../commons/net/ftp/parser/NTFTPEntryParser.java | 4 +- .../net/ftp/parser/NetwareFTPEntryParser.java | 6 +- .../commons/net/ftp/parser/OS2FTPEntryParser.java | 4 +- .../net/ftp/parser/OS400FTPEntryParser.java | 10 +- .../ftp/parser/ParserInitializationException.java | 2 +- .../ftp/parser/RegexFTPFileEntryParserImpl.java | 10 +- .../commons/net/ftp/parser/UnixFTPEntryParser.java | 16 +- .../commons/net/ftp/parser/VMSFTPEntryParser.java | 10 +- .../ftp/parser/VMSVersioningFTPEntryParser.java | 14 +- .../commons/net/imap/AuthenticatingIMAPClient.java | 55 ++-- .../java/org/apache/commons/net/imap/IMAP.java | 10 +- .../org/apache/commons/net/imap/IMAPClient.java | 14 +- .../org/apache/commons/net/imap/IMAPCommand.java | 125 +++++++- .../org/apache/commons/net/imap/IMAPReply.java | 12 +- .../org/apache/commons/net/imap/IMAPSClient.java | 6 +- .../commons/net/io/DotTerminatedMessageReader.java | 6 +- .../commons/net/io/DotTerminatedMessageWriter.java | 7 +- .../commons/net/io/FromNetASCIIInputStream.java | 2 - .../commons/net/io/FromNetASCIIOutputStream.java | 2 - .../commons/net/io/ToNetASCIIInputStream.java | 2 - .../commons/net/io/ToNetASCIIOutputStream.java | 2 - src/main/java/org/apache/commons/net/io/Util.java | 16 +- .../java/org/apache/commons/net/nntp/Article.java | 8 +- .../org/apache/commons/net/nntp/ArticleInfo.java | 2 - .../apache/commons/net/nntp/ArticleIterator.java | 1 - .../java/org/apache/commons/net/nntp/NNTP.java | 48 +-- .../org/apache/commons/net/nntp/NNTPClient.java | 115 +++---- .../org/apache/commons/net/nntp/NNTPCommand.java | 41 ++- .../net/nntp/NNTPConnectionClosedException.java | 1 - .../org/apache/commons/net/nntp/NNTPReply.java | 102 +++++- .../commons/net/nntp/NewGroupsOrNewsQuery.java | 22 +- .../org/apache/commons/net/nntp/NewsgroupInfo.java | 7 +- .../apache/commons/net/nntp/NewsgroupIterator.java | 1 - ...readContainer.java => NntpThreadContainer.java} | 20 +- .../org/apache/commons/net/nntp/ReplyIterator.java | 1 - .../apache/commons/net/nntp/SimpleNNTPHeader.java | 15 +- .../org/apache/commons/net/nntp/Threadable.java | 1 - .../java/org/apache/commons/net/nntp/Threader.java | 109 ++++--- .../org/apache/commons/net/ntp/NTPUDPClient.java | 12 +- .../java/org/apache/commons/net/ntp/NtpUtils.java | 7 +- .../java/org/apache/commons/net/ntp/NtpV3Impl.java | 41 ++- .../org/apache/commons/net/ntp/NtpV3Packet.java | 26 +- .../java/org/apache/commons/net/ntp/TimeInfo.java | 14 +- .../java/org/apache/commons/net/ntp/TimeStamp.java | 28 +- .../commons/net/pop3/ExtendedPOP3Client.java | 42 +-- .../java/org/apache/commons/net/pop3/POP3.java | 10 +- .../org/apache/commons/net/pop3/POP3Client.java | 42 +-- .../org/apache/commons/net/pop3/POP3Command.java | 6 +- .../apache/commons/net/pop3/POP3MessageInfo.java | 2 - .../org/apache/commons/net/pop3/POP3Reply.java | 2 +- .../org/apache/commons/net/pop3/POP3SClient.java | 6 +- .../commons/net/smtp/AuthenticatingSMTPClient.java | 57 ++-- .../org/apache/commons/net/smtp/RelayPath.java | 4 - .../java/org/apache/commons/net/smtp/SMTP.java | 42 +-- .../org/apache/commons/net/smtp/SMTPClient.java | 57 ++-- .../org/apache/commons/net/smtp/SMTPCommand.java | 64 +++- .../net/smtp/SMTPConnectionClosedException.java | 1 - .../org/apache/commons/net/smtp/SMTPReply.java | 68 +++- .../org/apache/commons/net/smtp/SMTPSClient.java | 6 +- .../apache/commons/net/smtp/SimpleSMTPHeader.java | 16 +- .../commons/net/telnet/EchoOptionHandler.java | 1 - .../net/telnet/InvalidTelnetOptionException.java | 2 - .../commons/net/telnet/SimpleOptionHandler.java | 2 - .../net/telnet/SuppressGAOptionHandler.java | 1 - .../java/org/apache/commons/net/telnet/Telnet.java | 51 +-- .../apache/commons/net/telnet/TelnetClient.java | 26 +- .../apache/commons/net/telnet/TelnetCommand.java | 6 +- .../commons/net/telnet/TelnetInputStream.java | 2 - .../net/telnet/TelnetNotificationHandler.java | 12 +- .../apache/commons/net/telnet/TelnetOption.java | 7 +- .../commons/net/telnet/TelnetOptionHandler.java | 78 ++--- .../commons/net/telnet/TelnetOutputStream.java | 9 +- .../net/telnet/TerminalTypeOptionHandler.java | 18 +- .../net/telnet/WindowSizeOptionHandler.java | 12 +- .../java/org/apache/commons/net/tftp/TFTP.java | 45 +-- .../org/apache/commons/net/tftp/TFTPAckPacket.java | 6 +- .../org/apache/commons/net/tftp/TFTPClient.java | 9 +- .../apache/commons/net/tftp/TFTPDataPacket.java | 6 +- .../apache/commons/net/tftp/TFTPErrorPacket.java | 4 +- .../org/apache/commons/net/tftp/TFTPPacket.java | 6 +- .../commons/net/tftp/TFTPReadRequestPacket.java | 2 +- .../commons/net/tftp/TFTPWriteRequestPacket.java | 2 +- .../org/apache/commons/net/time/TimeUDPClient.java | 26 +- .../java/org/apache/commons/net/util/Base64.java | 111 ++++--- .../java/org/apache/commons/net/util/Charsets.java | 2 +- .../apache/commons/net/util/KeyManagerUtils.java | 1 - .../apache/commons/net/util/SSLContextUtils.java | 5 +- .../apache/commons/net/util/SSLSocketUtils.java | 1 - .../org/apache/commons/net/util/SubnetUtils.java | 6 +- .../org/apache/commons/net/whois/WhoisClient.java | 3 - src/site/xdoc/download_net.xml | 26 +- .../org/apache/commons/net/SocketClientTest.java | 40 ++- .../org/apache/commons/net/SubnetUtilsTest.java | 139 ++++---- .../apache/commons/net/ftp/AbstractFtpsTest.java | 4 +- .../net/ftp/FTPClientConfigFunctionalTest.java | 2 +- .../commons/net/ftp/FTPClientConfigTest.java | 38 +-- .../org/apache/commons/net/ftp/FTPClientTest.java | 3 +- .../org/apache/commons/net/ftp/FTPCommandTest.java | 1 - .../org/apache/commons/net/ftp/FTPFileTest.java | 187 +++++++++++ .../net/ftp/NoProtocolSslConfigurationProxy.java | 4 +- ...estFramework.java => AbstractFTPParseTest.java} | 4 +- .../ftp/parser/CompositeFTPParseTestFramework.java | 2 +- .../DefaultFTPFileEntryParserFactoryTest.java | 18 +- .../commons/net/ftp/parser/DownloadListings.java | 15 +- .../parser/EnterpriseUnixFTPEntryParserTest.java | 13 +- .../net/ftp/parser/FTPConfigEntryParserTest.java | 1 - .../net/ftp/parser/FTPTimestampParserImplTest.java | 69 +--- .../commons/net/ftp/parser/MLSDComparison.java | 13 +- .../net/ftp/parser/MLSxEntryParserTest.java | 2 +- .../net/ftp/parser/MVSFTPEntryParserTest.java | 20 +- .../ftp/parser/MacOsPeterFTPEntryParserTest.java | 2 +- .../net/ftp/parser/NTFTPEntryParserTest.java | 6 +- .../net/ftp/parser/NetwareFTPEntryParserTest.java | 2 +- .../net/ftp/parser/OS2FTPEntryParserTest.java | 2 +- .../net/ftp/parser/OS400FTPEntryParserTest.java | 12 +- .../net/ftp/parser/UnixFTPEntryParserTest.java | 2 +- .../net/ftp/parser/VMSFTPEntryParserTest.java | 2 +- .../net/imap/AuthenticatingIMAPClientTest.java | 46 +++ .../apache/commons/net/imap/IMAPCommandTest.java | 67 ++++ .../org/apache/commons/net/imap/IMAPReplyTest.java | 186 +++++++++++ .../java/org/apache/commons/net/imap/IMAPTest.java | 67 +++- .../commons/net/io/ToNetASCIIInputStreamTest.java | 1 - .../org/apache/commons/net/ntp/TestNtpClient.java | 3 +- .../org/apache/commons/net/ntp/TestTimeInfo.java | 2 +- .../commons/net/pop3/POP3ClientCommandsTest.java | 7 +- .../org/apache/commons/net/pop3/POP3Constants.java | 2 +- ...t.java => AbstractTelnetOptionHandlerTest.java} | 2 +- .../commons/net/telnet/EchoOptionHandlerTest.java | 10 +- .../net/telnet/SimpleOptionHandlerTest.java | 10 +- .../net/telnet/SuppressGAOptionHandlerTest.java | 10 +- .../net/telnet/TelnetClientFunctionalTest.java | 9 +- .../commons/net/telnet/TelnetClientTest.java | 97 +++--- .../commons/net/telnet/TelnetTestResponder.java | 2 +- .../net/telnet/TerminalTypeOptionHandlerTest.java | 16 +- .../net/telnet/WindowSizeOptionHandlerTest.java | 10 +- .../org/apache/commons/net/tftp/TFTPServer.java | 354 +++++++++++---------- .../apache/commons/net/tftp/TFTPServerMain.java | 6 +- .../commons/net/tftp/TFTPServerPathTest.java | 249 +++++++++------ .../java/org/apache/commons/net/tftp/TFTPTest.java | 150 ++++----- .../commons/net/time/TimeTestSimpleServer.java | 1 - .../org/apache/commons/net/util/Base64Test.java | 85 +++-- .../java/org/apache/commons/net/util/UtilTest.java | 1 - 221 files changed, 3697 insertions(+), 2217 deletions(-) rename checkstyle-suppressions.xml => src/conf/checkstyle-suppressions.xml (100%) rename checkstyle.xml => src/conf/checkstyle.xml (96%) rename findbugs-exclude-filter.xml => src/conf/findbugs-exclude-filter.xml (100%) rename src/main/java/org/apache/commons/net/nntp/{ThreadContainer.java => NntpThreadContainer.java} (83%) create mode 100644 src/test/java/org/apache/commons/net/ftp/FTPFileTest.java rename src/test/java/org/apache/commons/net/ftp/parser/{FTPParseTestFramework.java => AbstractFTPParseTest.java} (98%) create mode 100644 src/test/java/org/apache/commons/net/imap/AuthenticatingIMAPClientTest.java create mode 100644 src/test/java/org/apache/commons/net/imap/IMAPCommandTest.java create mode 100644 src/test/java/org/apache/commons/net/imap/IMAPReplyTest.java rename src/test/java/org/apache/commons/net/telnet/{TelnetOptionHandlerTestAbstract.java => AbstractTelnetOptionHandlerTest.java} (98%)