[commons-io] branch master updated: [IO-811] Files.walk() direct and indirect callers fail to close the returned Stream

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 3c4f0258 [IO-811] Files.walk() direct and indirect callers fail to 
close the returned Stream<Path>
3c4f0258 is described below

commit 3c4f02586e687f9e3177a6c37d262b18684112be
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Sep 30 09:24:10 2023 -0400

    [IO-811] Files.walk() direct and indirect callers fail to close the
    returned Stream<Path>
    
    - Javadoc
    - Use final
---
 .../java/org/apache/commons/io/FileUtilsListFilesTest.java   | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/test/java/org/apache/commons/io/FileUtilsListFilesTest.java 
b/src/test/java/org/apache/commons/io/FileUtilsListFilesTest.java
index 10897092..93b79001 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsListFilesTest.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsListFilesTest.java
@@ -46,6 +46,12 @@ public class FileUtilsListFilesTest {
         return files.stream().map(File::getName).collect(Collectors.toList());
     }
 
+    /**
+     * Consumes and closes the underlying stream.
+     *
+     * @param files The iterator to consume.
+     * @return a new collection.
+     */
     private Collection<String> filesToFilenames(final Iterator<File> files) {
         final Collection<String> fileNames = new ArrayList<>();
         // Iterator.forEachRemaining() closes the underlying stream.
@@ -91,7 +97,7 @@ public class FileUtilsListFilesTest {
 
         Iterator<File> files = FileUtils.iterateFiles(temporaryFolder, 
extensions, false);
         try {
-            Collection<String> filenames = filesToFilenames(files);
+            final Collection<String> filenames = filesToFilenames(files);
             assertEquals(1, filenames.size());
             assertTrue(filenames.contains("dummy-build.xml"));
             assertFalse(filenames.contains("README"));
@@ -103,7 +109,7 @@ public class FileUtilsListFilesTest {
 
         try {
             files = FileUtils.iterateFiles(temporaryFolder, extensions, true);
-            Collection<String> filenames = filesToFilenames(files);
+            final Collection<String> filenames = filesToFilenames(files);
             assertEquals(4, filenames.size());
             assertTrue(filenames.contains("dummy-file.txt"));
             assertFalse(filenames.contains("dummy-index.html"));
@@ -114,7 +120,7 @@ public class FileUtilsListFilesTest {
 
         files = FileUtils.iterateFiles(temporaryFolder, null, false);
         try {
-            Collection<String> filenames = filesToFilenames(files);
+            final Collection<String> filenames = filesToFilenames(files);
             assertEquals(2, filenames.size());
             assertTrue(filenames.contains("dummy-build.xml"));
             assertTrue(filenames.contains("README"));