This is an automated email from the ASF dual-hosted git repository.

tv pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jcs.git


The following commit(s) were added to refs/heads/master by this push:
     new 18d9fc84 Make all test loops run the correct number of times
18d9fc84 is described below

commit 18d9fc842bf254e44d08d160fc8cde98acd3a6dd
Author: Thomas Vandahl <t...@apache.org>
AuthorDate: Thu Aug 24 23:32:23 2023 +0200

    Make all test loops run the correct number of times
---
 .../apache/commons/jcs3/JCSLightLoadUnitTest.java    |  8 ++------
 .../org/apache/commons/jcs3/TestTCPLateralCache.java |  8 ++++----
 .../apache/commons/jcs3/ZeroSizeCacheUnitTest.java   |  4 ++--
 .../disk/block/AbstractBlockDiskCacheUnitTest.java   |  4 ++--
 .../block/HugeQuantityBlockDiskCacheLoadTest.java    |  4 ++--
 .../disk/indexed/AbstractIndexDiskCacheUnitTest.java |  4 ++--
 .../indexed/HugeQuantityIndDiskCacheLoadTest.java    |  8 ++++----
 .../indexed/IndexedDiskCacheConcurrentUnitTest.java  | 12 ++++++------
 .../indexed/IndexedDiskCacheNoMemoryUnitTest.java    | 12 ++++++------
 .../disk/jdbc/JDBCDiskCacheSharedPoolUnitTest.java   | 12 ++++++------
 .../jdbc/hsql/HSQLDiskCacheConcurrentUnitTest.java   | 12 ++++++------
 .../disk/jdbc/hsql/HSQLDiskCacheUnitTest.java        | 20 ++++++++++----------
 .../http/client/RemoteHttpCacheManualTester.java     |  2 +-
 13 files changed, 53 insertions(+), 57 deletions(-)

diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/JCSLightLoadUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/JCSLightLoadUnitTest.java
index 274027ba..9479fbf8 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/JCSLightLoadUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/JCSLightLoadUnitTest.java
@@ -41,7 +41,6 @@ public class JCSLightLoadUnitTest
         throws Exception
     {
         JCS.setConfigFilename( "/TestSimpleLoad.ccf" );
-        JCS.getInstance( "testCache1" );
     }
 
     /**
@@ -52,16 +51,13 @@ public class JCSLightLoadUnitTest
         throws Exception
     {
         final CacheAccess<String, String> jcs = JCS.getInstance( "testCache1" 
);
-        //        ICompositeCacheAttributes cattr = jcs.getCacheAttributes();
-        //        cattr.setMaxObjects( 20002 );
-        //        jcs.setCacheAttributes( cattr );
 
-        for ( int i = 1; i <= items; i++ )
+        for ( int i = 1; i < items; i++ )
         {
             jcs.put( i + ":key", "data" + i );
         }
 
-        for ( int i = items; i > 0; i-- )
+        for ( int i = items-1; i > 0; i-- )
         {
             final String res = jcs.get( i + ":key" );
             assertNotNull( "[" + i + ":key] should not be null", res );
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/TestTCPLateralCache.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/TestTCPLateralCache.java
index 4ec788aa..c53389ff 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/TestTCPLateralCache.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/TestTCPLateralCache.java
@@ -112,14 +112,14 @@ public class TestTCPLateralCache
 
         // Add items to cache
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
 
         // Test that all items are in cache
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
 
@@ -128,14 +128,14 @@ public class TestTCPLateralCache
 
         // Remove all the items
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.remove( i + ":key" );
         }
 
         // Verify removal
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             assertNull( "Removed key should be null: " + i + ":key", jcs.get( 
i + ":key" ) );
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/ZeroSizeCacheUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/ZeroSizeCacheUnitTest.java
index 16764435..2705a996 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/ZeroSizeCacheUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/ZeroSizeCacheUnitTest.java
@@ -55,7 +55,7 @@ public class ZeroSizeCacheUnitTest
     {
         final CacheAccess<String, String> jcs = JCS.getInstance( "testCache1" 
);
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", "data" + i );
         }
@@ -74,7 +74,7 @@ public class ZeroSizeCacheUnitTest
         Thread.sleep( 500 );
 
         // do it again.
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", "data" + i );
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/AbstractBlockDiskCacheUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/AbstractBlockDiskCacheUnitTest.java
index c5c10202..be70a4c0 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/AbstractBlockDiskCacheUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/AbstractBlockDiskCacheUnitTest.java
@@ -53,7 +53,7 @@ public abstract class AbstractBlockDiskCacheUnitTest extends 
TestCase
         final BlockDiskCache<String, String> diskCache = new 
BlockDiskCache<>(cattr);
 
         // DO WORK
-        for (int i = 0; i <= items; i++)
+        for (int i = 0; i < items; i++)
         {
             diskCache.update(new CacheElement<>(cacheName, i + ":key", 
cacheName + " data " + i));
         }
@@ -86,7 +86,7 @@ public abstract class AbstractBlockDiskCacheUnitTest extends 
TestCase
         final BlockDiskCache<String, String> diskCache = new 
BlockDiskCache<>(cattr);
 
         // DO WORK
-        for (int i = 0; i <= items; i++)
+        for (int i = 0; i < items; i++)
         {
             diskCache.update(new CacheElement<>(cacheName, i + ":key", 
cacheName + " data " + i));
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/HugeQuantityBlockDiskCacheLoadTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/HugeQuantityBlockDiskCacheLoadTest.java
index 943f84f3..734d2a3c 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/HugeQuantityBlockDiskCacheLoadTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/block/HugeQuantityBlockDiskCacheLoadTest.java
@@ -67,7 +67,7 @@ public class HugeQuantityBlockDiskCacheLoadTest
             System.out.println( "Start: " + measureMemoryUse() );
 
             // Add items to cache
-            for ( int i = 0; i <= items; i++ )
+            for ( int i = 0; i < items; i++ )
             {
                 jcs.put( i + ":key", region + " data " + i );
             }
@@ -94,7 +94,7 @@ public class HugeQuantityBlockDiskCacheLoadTest
             // Test that all items are in cache
             System.out.println( "--------------------------" );
             System.out.println( "Retrieving all." );
-            for ( int i = 0; i <= items; i++ )
+            for ( int i = 0; i < items; i++ )
             {
                 //System.out.print(  "\033[s" );
                 final String value = jcs.get( i + ":key" );
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/AbstractIndexDiskCacheUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/AbstractIndexDiskCacheUnitTest.java
index 15f149af..aac71335 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/AbstractIndexDiskCacheUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/AbstractIndexDiskCacheUnitTest.java
@@ -661,7 +661,7 @@ public abstract class AbstractIndexDiskCacheUnitTest 
extends TestCase
         final IndexedDiskCache<String, String> diskCache = new 
IndexedDiskCache<>(cattr);
 
         // DO WORK
-        for (int i = 0; i <= items; i++)
+        for (int i = 0; i < items; i++)
         {
             diskCache.update(new CacheElement<>(cacheName, i + ":key", 
cacheName + " data " + i));
         }
@@ -694,7 +694,7 @@ public abstract class AbstractIndexDiskCacheUnitTest 
extends TestCase
         final IndexedDiskCache<String, String> diskCache = new 
IndexedDiskCache<>(cattr);
 
         // DO WORK
-        for (int i = 0; i <= items; i++)
+        for (int i = 0; i < items; i++)
         {
             diskCache.update(new CacheElement<>(cacheName, i + ":key", 
cacheName + " data " + i));
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/HugeQuantityIndDiskCacheLoadTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/HugeQuantityIndDiskCacheLoadTest.java
index fe685e77..539b8944 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/HugeQuantityIndDiskCacheLoadTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/HugeQuantityIndDiskCacheLoadTest.java
@@ -57,7 +57,7 @@ public class HugeQuantityIndDiskCacheLoadTest
 
             // Add items to cache
 
-            for ( int i = 0; i <= items; i++ )
+            for ( int i = 0; i < items; i++ )
             {
                 jcs.put( i + ":key", region + " data " + i );
             }
@@ -74,7 +74,7 @@ public class HugeQuantityIndDiskCacheLoadTest
 
             // Test that all items are in cache
 
-            for ( int i = 0; i <= items; i++ )
+            for ( int i = 0; i < items; i++ )
             {
                 final String value = jcs.get( i + ":key" );
 
@@ -84,13 +84,13 @@ public class HugeQuantityIndDiskCacheLoadTest
             System.out.println( "After get: " + measureMemoryUse() );
 
             // // Remove all the items
-            // for ( int i = 0; i <= items; i++ )
+            // for ( int i = 0; i < items; i++ )
             // {
             // jcs.remove( i + ":key" );
             // }
             //
             // // Verify removal
-            // for ( int i = 0; i <= items; i++ )
+            // for ( int i = 0; i < items; i++ )
             // {
             // assertNull( "Removed key should be null: " + i + ":key" + "\n
             // stats " + jcs.getStats(), jcs.get( i + ":key" ) );
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheConcurrentUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheConcurrentUnitTest.java
index f0a2461d..3621ade2 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheConcurrentUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheConcurrentUnitTest.java
@@ -131,13 +131,13 @@ public class IndexedDiskCacheConcurrentUnitTest
         final CacheAccess<String, String> jcs = JCS.getInstance( region );
 
         // Add items to cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
 
         // Test that all items are in cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
 
@@ -146,13 +146,13 @@ public class IndexedDiskCacheConcurrentUnitTest
 
         // Test that getElements returns all the expected values
         final Set<String> keys = new HashSet<>();
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             keys.add( i + ":key" );
         }
 
         final Map<String, ICacheElement<String, String>> elements = 
jcs.getCacheElements( keys );
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final ICacheElement<String, String> element = elements.get( i + 
":key" );
             assertNotNull( "element " + i + ":key is missing", element );
@@ -160,14 +160,14 @@ public class IndexedDiskCacheConcurrentUnitTest
         }
 
         // Remove all the items
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.remove( i + ":key" );
         }
 
         // Verify removal
         // another thread may have inserted since
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             assertNull( "Removed key should be null: " + i + ":key" + "\n 
stats " + jcs.getStats(), jcs
                 .get( i + ":key" ) );
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheNoMemoryUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheNoMemoryUnitTest.java
index 4cda36b8..063bb3ac 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheNoMemoryUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCacheNoMemoryUnitTest.java
@@ -121,14 +121,14 @@ public class IndexedDiskCacheNoMemoryUnitTest
 
         // Add items to cache
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
 
         // Test that all items are in cache
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
 
@@ -137,13 +137,13 @@ public class IndexedDiskCacheNoMemoryUnitTest
 
         // Test that getElements returns all the expected values
         final Set<String> keys = new HashSet<>();
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             keys.add( i + ":key" );
         }
 
         final Map<String, ICacheElement<String, String>> elements = 
jcs.getCacheElements( keys );
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final ICacheElement<String, String> element = elements.get( i + 
":key" );
             assertNotNull( "element " + i + ":key is missing", element );
@@ -151,13 +151,13 @@ public class IndexedDiskCacheNoMemoryUnitTest
         }
 
         // Remove all the items
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.remove( i + ":key" );
         }
 
         // Verify removal
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             assertNull( "Removed key should be null: " + i + ":key" + "\n 
stats " + jcs.getStats(), jcs.get( i + ":key" ) );
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/JDBCDiskCacheSharedPoolUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/JDBCDiskCacheSharedPoolUnitTest.java
index 250e1d88..cfa01687 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/JDBCDiskCacheSharedPoolUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/JDBCDiskCacheSharedPoolUnitTest.java
@@ -77,7 +77,7 @@ public class JDBCDiskCacheSharedPoolUnitTest
 
         // Add items to cache
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
@@ -85,7 +85,7 @@ public class JDBCDiskCacheSharedPoolUnitTest
         Thread.sleep( 1000 );
 
         // Test that all items are in cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
 
@@ -94,13 +94,13 @@ public class JDBCDiskCacheSharedPoolUnitTest
 
         // Test that getElements returns all the expected values
         final Set<String> keys = new HashSet<>();
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             keys.add( i + ":key" );
         }
 
         final Map<String, ICacheElement<String, String>> elements = 
jcs.getCacheElements( keys );
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final ICacheElement<String, String> element = elements.get( i + 
":key" );
             assertNotNull( "element " + i + ":key is missing", element );
@@ -108,13 +108,13 @@ public class JDBCDiskCacheSharedPoolUnitTest
         }
 
         // Remove all the items
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.remove( i + ":key" );
         }
 
         // Verify removal
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             assertNull( "Removed key should be null: " + i + ":key", jcs.get( 
i + ":key" ) );
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheConcurrentUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheConcurrentUnitTest.java
index 85751f6a..991d74f0 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheConcurrentUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheConcurrentUnitTest.java
@@ -116,13 +116,13 @@ public class HSQLDiskCacheConcurrentUnitTest
         final CacheAccess<String, String> jcs = JCS.getInstance( region );
 
         // Add items to cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
 
         // Test that all items are in cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
 
@@ -131,13 +131,13 @@ public class HSQLDiskCacheConcurrentUnitTest
 
         // Test that getElements returns all the expected values
         final Set<String> keys = new HashSet<>();
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             keys.add( i + ":key" );
         }
 
         final Map<String, ICacheElement<String, String>> elements = 
jcs.getCacheElements( keys );
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final ICacheElement<String, String> element = elements.get( i + 
":key" );
             assertNotNull( "element " + i + ":key is missing", element );
@@ -145,13 +145,13 @@ public class HSQLDiskCacheConcurrentUnitTest
         }
 
         // Remove all the items
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.remove( i + ":key" );
         }
 
         // Verify removal
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             assertNull( "Removed key should be null: " + i + ":key", jcs.get( 
i + ":key" ) );
         }
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheUnitTest.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheUnitTest.java
index 741b8c54..6458c9d5 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheUnitTest.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/disk/jdbc/hsql/HSQLDiskCacheUnitTest.java
@@ -61,13 +61,13 @@ public class HSQLDiskCacheUnitTest
         final CacheAccess<String, String> jcs = JCS.getInstance( region );
 
         // Add items to cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
 
         // Test that all items are in cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
             assertEquals( "key = [" + i + ":key] value = [" + value + "]", 
region + " data " + i, value );
@@ -75,13 +75,13 @@ public class HSQLDiskCacheUnitTest
 
         // Test that getElements returns all the expected values
         final Set<String> keys = new HashSet<>();
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             keys.add( i + ":key" );
         }
 
         final Map<String, ICacheElement<String, String>> elements = 
jcs.getCacheElements( keys );
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final ICacheElement<String, String> element = elements.get( i + 
":key" );
             assertNotNull( "element " + i + ":key is missing", element );
@@ -89,13 +89,13 @@ public class HSQLDiskCacheUnitTest
         }
 
         // Remove all the items
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.remove( i + ":key" );
         }
 
         // Verify removal
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             assertNull( "Removed key should be null: " + i + ":key", jcs.get( 
i + ":key" ) );
         }
@@ -116,7 +116,7 @@ public class HSQLDiskCacheUnitTest
         final int items = 20;
 
         // Add items to cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
@@ -132,7 +132,7 @@ public class HSQLDiskCacheUnitTest
 
         jcs.clear();
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
             assertNull( "value should be null key = [" + i + ":key] value = [" 
+ value + "]", value );
@@ -154,7 +154,7 @@ public class HSQLDiskCacheUnitTest
         final int items = 20;
 
         // Add items to cache
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             jcs.put( i + ":key", region + " data " + i );
         }
@@ -164,7 +164,7 @@ public class HSQLDiskCacheUnitTest
 
         jcs.clear();
 
-        for ( int i = 0; i <= items; i++ )
+        for ( int i = 0; i < items; i++ )
         {
             final String value = jcs.get( i + ":key" );
             assertEquals( "key = [" + i + ":key] value = [" + value + "]", 
region + " data " + i, value );
diff --git 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/remote/http/client/RemoteHttpCacheManualTester.java
 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/remote/http/client/RemoteHttpCacheManualTester.java
index 0af08bdd..135409ea 100644
--- 
a/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/remote/http/client/RemoteHttpCacheManualTester.java
+++ 
b/commons-jcs3-core/src/test/java/org/apache/commons/jcs3/auxiliary/remote/http/client/RemoteHttpCacheManualTester.java
@@ -53,7 +53,7 @@ public class RemoteHttpCacheManualTester
 
 //        System.out.println( jcs.getStats() );
 
-        for ( int i = 1; i <= items; i++ )
+        for ( int i = 1; i < items; i++ )
         {
             jcs.put( i + ":key", "data" + i );
         }

Reply via email to