This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
The following commit(s) were added to refs/heads/master by this push:
new ee902fce Better internal class name
ee902fce is described below
commit ee902fceaa8d96dc0bce0aaa8cac5ec2385109a4
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Aug 19 07:53:14 2023 -0400
Better internal class name
---
...{FTPParseTestFramework.java => AbstractFTPParseTest.java} | 4 ++--
.../net/ftp/parser/CompositeFTPParseTestFramework.java | 2 +-
.../net/ftp/parser/EnterpriseUnixFTPEntryParserTest.java | 12 ++++++------
.../apache/commons/net/ftp/parser/MLSxEntryParserTest.java | 2 +-
.../apache/commons/net/ftp/parser/MVSFTPEntryParserTest.java | 4 ++--
.../commons/net/ftp/parser/MacOsPeterFTPEntryParserTest.java | 2 +-
.../apache/commons/net/ftp/parser/NTFTPEntryParserTest.java | 6 +++---
.../commons/net/ftp/parser/NetwareFTPEntryParserTest.java | 2 +-
.../apache/commons/net/ftp/parser/OS2FTPEntryParserTest.java | 2 +-
.../commons/net/ftp/parser/OS400FTPEntryParserTest.java | 10 +++++-----
.../commons/net/ftp/parser/UnixFTPEntryParserTest.java | 2 +-
.../apache/commons/net/ftp/parser/VMSFTPEntryParserTest.java | 2 +-
...estAbstract.java => AbstractTelnetOptionHandlerTest.java} | 2 +-
.../org/apache/commons/net/telnet/EchoOptionHandlerTest.java | 2 +-
.../apache/commons/net/telnet/SimpleOptionHandlerTest.java | 2 +-
.../commons/net/telnet/SuppressGAOptionHandlerTest.java | 2 +-
.../commons/net/telnet/TerminalTypeOptionHandlerTest.java | 2 +-
.../commons/net/telnet/WindowSizeOptionHandlerTest.java | 2 +-
18 files changed, 31 insertions(+), 31 deletions(-)
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java
b/src/test/java/org/apache/commons/net/ftp/parser/AbstractFTPParseTest.java
similarity index 98%
rename from
src/test/java/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java
rename to
src/test/java/org/apache/commons/net/ftp/parser/AbstractFTPParseTest.java
index 2fbba3ab..0975ed89 100644
--- a/src/test/java/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java
+++ b/src/test/java/org/apache/commons/net/ftp/parser/AbstractFTPParseTest.java
@@ -28,7 +28,7 @@ import junit.framework.TestCase;
/**
*/
-public abstract class FTPParseTestFramework extends TestCase {
+public abstract class AbstractFTPParseTest extends TestCase {
// associate Calendar unit ints with a readable string
// MUST be listed least significant first, as the routine needs to
// find the previous - less significant - entry
@@ -50,7 +50,7 @@ public abstract class FTPParseTestFramework extends TestCase {
/**
* @see junit.framework.TestCase#TestCase(String)
*/
- public FTPParseTestFramework(final String name) {
+ public AbstractFTPParseTest(final String name) {
super(name);
}
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java
b/src/test/java/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java
index 59e9723d..836546a8 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java
@@ -21,7 +21,7 @@ import org.apache.commons.net.ftp.FTPFileEntryParser;
/**
*/
-public abstract class CompositeFTPParseTestFramework extends
FTPParseTestFramework {
+public abstract class CompositeFTPParseTestFramework extends
AbstractFTPParseTest {
public CompositeFTPParseTestFramework(final String name) {
super(name);
}
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/EnterpriseUnixFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/EnterpriseUnixFTPEntryParserTest.java
index 0ab1bdb7..4028a748 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/EnterpriseUnixFTPEntryParserTest.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/EnterpriseUnixFTPEntryParserTest.java
@@ -29,7 +29,7 @@ import org.apache.commons.net.ftp.FTPFileEntryParser;
/**
* Tests the EnterpriseUnixFTPEntryParser
*/
-public class EnterpriseUnixFTPEntryParserTest extends FTPParseTestFramework {
+public class EnterpriseUnixFTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] BADSAMPLES = { "zrwxr-xr-x 2 root root
4096 Mar 2 15:13 zxbox",
"dxrwr-xr-x 2 root root 4096 Aug 24 2001 zxjdbc",
"drwxr-xr-x 2 root root 4096 Jam 4 00:03 zziplib",
@@ -78,7 +78,7 @@ public class EnterpriseUnixFTPEntryParserTest extends
FTPParseTestFramework {
}
/**
- * @see
org.apache.commons.net.ftp.parser.FTPParseTestFramework#getBadListing()
+ * @see
org.apache.commons.net.ftp.parser.AbstractFTPParseTest#getBadListing()
*/
@Override
protected String[] getBadListing() {
@@ -86,7 +86,7 @@ public class EnterpriseUnixFTPEntryParserTest extends
FTPParseTestFramework {
}
/**
- * @see
org.apache.commons.net.ftp.parser.FTPParseTestFramework#getGoodListing()
+ * @see
org.apache.commons.net.ftp.parser.AbstractFTPParseTest#getGoodListing()
*/
@Override
protected String[] getGoodListing() {
@@ -94,7 +94,7 @@ public class EnterpriseUnixFTPEntryParserTest extends
FTPParseTestFramework {
}
/**
- * @see org.apache.commons.net.ftp.parser.FTPParseTestFramework#getParser()
+ * @see org.apache.commons.net.ftp.parser.AbstractFTPParseTest#getParser()
*/
@Override
protected FTPFileEntryParser getParser() {
@@ -107,7 +107,7 @@ public class EnterpriseUnixFTPEntryParserTest extends
FTPParseTestFramework {
}
/**
- * @see
org.apache.commons.net.ftp.parser.FTPParseTestFramework#testParseFieldsOnDirectory()
+ * @see
org.apache.commons.net.ftp.parser.AbstractFTPParseTest#testParseFieldsOnDirectory()
*/
@Override
public void testParseFieldsOnDirectory() throws Exception {
@@ -115,7 +115,7 @@ public class EnterpriseUnixFTPEntryParserTest extends
FTPParseTestFramework {
}
/**
- * @see
org.apache.commons.net.ftp.parser.FTPParseTestFramework#testParseFieldsOnFile()
+ * @see
org.apache.commons.net.ftp.parser.AbstractFTPParseTest#testParseFieldsOnFile()
*/
@Override
public void testParseFieldsOnFile() throws Exception {
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/MLSxEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/MLSxEntryParserTest.java
index 01c2fe10..3cc80770 100644
--- a/src/test/java/org/apache/commons/net/ftp/parser/MLSxEntryParserTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/parser/MLSxEntryParserTest.java
@@ -21,7 +21,7 @@ import org.apache.commons.net.ftp.FTPFileEntryParser;
/**
*/
-public class MLSxEntryParserTest extends FTPParseTestFramework {
+public class MLSxEntryParserTest extends AbstractFTPParseTest {
private static final String[] badsamples = {
"Type=cdir;Modify=20141022065101;UNIX.mode=0775;/no/space", // no space between
facts and name
"Type=cdir;Modify=20141022065103;UNIX.mode=0775;", // no name or
space
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParserTest.java
index 5cd868d7..4b361e29 100644
--- a/src/test/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParserTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParserTest.java
@@ -26,7 +26,7 @@ import org.apache.commons.net.ftp.FTPFileEntryParser;
/**
* Test suite addapted to new MVSFTPEntryParser.java.
*/
-public class MVSFTPEntryParserTest extends FTPParseTestFramework {
+public class MVSFTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] goodsamplesDatasetList = {
/* Note, if the string begins with SAVE, the parsed entry is
stored in the List saveftpfiles */
@@ -110,7 +110,7 @@ public class MVSFTPEntryParserTest extends
FTPParseTestFramework {
}
/**
- * @see org.apache.commons.net.ftp.parser.FTPParseTestFramework#getParser()
+ * @see org.apache.commons.net.ftp.parser.AbstractFTPParseTest#getParser()
*/
@Override
protected FTPFileEntryParser getParser() {
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParserTest.java
index 6aa6a4d2..3dd88cd7 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParserTest.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParserTest.java
@@ -21,7 +21,7 @@ import java.util.Calendar;
import org.apache.commons.net.ftp.FTPFile;
import org.apache.commons.net.ftp.FTPFileEntryParser;
-public class MacOsPeterFTPEntryParserTest extends FTPParseTestFramework {
+public class MacOsPeterFTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] badsamples = { "drwxr-xr-x 123
folder 0 Jan 4 14:49 Steak", };
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryParserTest.java
index 5db1de1e..ebafc204 100644
--- a/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryParserTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryParserTest.java
@@ -125,7 +125,7 @@ public class NTFTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see org.apache.commons.net.ftp.parser.FTPParseTestFramework#getParser()
+ * @see org.apache.commons.net.ftp.parser.AbstractFTPParseTest#getParser()
*/
@Override
protected FTPFileEntryParser getParser() {
@@ -202,7 +202,7 @@ public class NTFTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see
org.apache.commons.net.ftp.parser.FTPParseTestFramework#testParseFieldsOnDirectory()
+ * @see
org.apache.commons.net.ftp.parser.AbstractFTPParseTest#testParseFieldsOnDirectory()
*/
@Override
public void testParseFieldsOnDirectory() throws Exception {
@@ -222,7 +222,7 @@ public class NTFTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see
org.apache.commons.net.ftp.parser.FTPParseTestFramework#testParseFieldsOnFile()
+ * @see
org.apache.commons.net.ftp.parser.AbstractFTPParseTest#testParseFieldsOnFile()
*/
@Override
public void testParseFieldsOnFile() throws Exception {
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
index a41dfc62..5f140649 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
@@ -23,7 +23,7 @@ import org.apache.commons.net.ftp.FTPFileEntryParser;
/**
*/
-public class NetwareFTPEntryParserTest extends FTPParseTestFramework {
+public class NetwareFTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] badsamples = { "a [-----F--] SCION_SYS
512 Apr 13 23:52 SYS",
"d [----AF--] 0 512 10-04-2001
_ADMIN" };
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParserTest.java
index af3bf2e5..da9d2d63 100644
--- a/src/test/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParserTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParserTest.java
@@ -19,7 +19,7 @@ package org.apache.commons.net.ftp.parser;
import org.apache.commons.net.ftp.FTPFile;
import org.apache.commons.net.ftp.FTPFileEntryParser;
-public class OS2FTPEntryParserTest extends FTPParseTestFramework {
+public class OS2FTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] badsamples = { " DIR
12-30-97 12:32 jbrekke", " 0 rsa DIR 11-25-97 09:42 junk",
" 0 dir 05-12-97 16:44 LANGUAGE", " 0
DIR 13-05-97 25:49 MPTN",
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParserTest.java
index 07f473e2..b67b4f78 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParserTest.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParserTest.java
@@ -57,7 +57,7 @@ public class OS400FTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see FTPParseTestFramework#getBadListing()
+ * @see AbstractFTPParseTest#getBadListing()
*/
@Override
protected String[][] getBadListings() {
@@ -65,7 +65,7 @@ public class OS400FTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see FTPParseTestFramework#getGoodListing()
+ * @see AbstractFTPParseTest#getGoodListing()
*/
@Override
protected String[][] getGoodListings() {
@@ -73,7 +73,7 @@ public class OS400FTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see FTPParseTestFramework#getParser()
+ * @see AbstractFTPParseTest#getParser()
*/
@Override
protected FTPFileEntryParser getParser() {
@@ -110,7 +110,7 @@ public class OS400FTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see FTPParseTestFramework#testParseFieldsOnDirectory()
+ * @see AbstractFTPParseTest#testParseFieldsOnDirectory()
*/
@Override
public void testParseFieldsOnDirectory() throws Exception {
@@ -134,7 +134,7 @@ public class OS400FTPEntryParserTest extends
CompositeFTPParseTestFramework {
}
/**
- * @see FTPParseTestFramework#testParseFieldsOnFile()
+ * @see AbstractFTPParseTest#testParseFieldsOnFile()
*/
@Override
public void testParseFieldsOnFile() throws Exception {
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
index da288465..2dc1da96 100644
---
a/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
+++
b/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
@@ -23,7 +23,7 @@ import org.apache.commons.net.ftp.FTPFileEntryParser;
/**
*/
-public class UnixFTPEntryParserTest extends FTPParseTestFramework {
+public class UnixFTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] badsamples = { "zrwxr-xr-x 2 root root
4096 Mar 2 15:13 zxbox",
"dxrwr-xr-x 2 root root 4096 Aug 24 2001 zxjdbc",
"drwxr-xr-x 2 root root 4096 Jam 4 00:03 zziplib",
diff --git
a/src/test/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParserTest.java
b/src/test/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParserTest.java
index e3afde28..29be8edc 100644
--- a/src/test/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParserTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParserTest.java
@@ -25,7 +25,7 @@ import org.apache.commons.net.ftp.FTPListParseEngine;
/**
*/
-public class VMSFTPEntryParserTest extends FTPParseTestFramework {
+public class VMSFTPEntryParserTest extends AbstractFTPParseTest {
private static final String[] BAD_SAMPLES = {
"1-JUN.LIS;2 9/9 JUN-2-1998 07:32:04
[GROUP,OWNER] (RWED,RWED,RWED,)",
diff --git
a/src/test/java/org/apache/commons/net/telnet/TelnetOptionHandlerTestAbstract.java
b/src/test/java/org/apache/commons/net/telnet/AbstractTelnetOptionHandlerTest.java
similarity index 98%
rename from
src/test/java/org/apache/commons/net/telnet/TelnetOptionHandlerTestAbstract.java
rename to
src/test/java/org/apache/commons/net/telnet/AbstractTelnetOptionHandlerTest.java
index 272e2698..d7942b49 100644
---
a/src/test/java/org/apache/commons/net/telnet/TelnetOptionHandlerTestAbstract.java
+++
b/src/test/java/org/apache/commons/net/telnet/AbstractTelnetOptionHandlerTest.java
@@ -22,7 +22,7 @@ import junit.framework.TestCase;
* The TelnetOptionHandlerTest is the abstract class for testing
TelnetOptionHandler. It can be used to derive the actual test classes for
TelnetOptionHadler
* derived classes, by adding creation of three new option handlers and
testing of the specific subnegotiation behavior.
*/
-public abstract class TelnetOptionHandlerTestAbstract extends TestCase {
+public abstract class AbstractTelnetOptionHandlerTest extends TestCase {
TelnetOptionHandler opthand1;
TelnetOptionHandler opthand2;
TelnetOptionHandler opthand3;
diff --git
a/src/test/java/org/apache/commons/net/telnet/EchoOptionHandlerTest.java
b/src/test/java/org/apache/commons/net/telnet/EchoOptionHandlerTest.java
index be9b3680..b2cb3861 100644
--- a/src/test/java/org/apache/commons/net/telnet/EchoOptionHandlerTest.java
+++ b/src/test/java/org/apache/commons/net/telnet/EchoOptionHandlerTest.java
@@ -19,7 +19,7 @@ package org.apache.commons.net.telnet;
/**
* JUnit test class for EchoOptionHandler
*/
-public class EchoOptionHandlerTest extends TelnetOptionHandlerTestAbstract {
+public class EchoOptionHandlerTest extends AbstractTelnetOptionHandlerTest {
/**
* setUp for the test.
diff --git
a/src/test/java/org/apache/commons/net/telnet/SimpleOptionHandlerTest.java
b/src/test/java/org/apache/commons/net/telnet/SimpleOptionHandlerTest.java
index a559f472..e41b23cf 100644
--- a/src/test/java/org/apache/commons/net/telnet/SimpleOptionHandlerTest.java
+++ b/src/test/java/org/apache/commons/net/telnet/SimpleOptionHandlerTest.java
@@ -19,7 +19,7 @@ package org.apache.commons.net.telnet;
/**
* JUnit test class for SimpleOptionHandler
*/
-public class SimpleOptionHandlerTest extends TelnetOptionHandlerTestAbstract {
+public class SimpleOptionHandlerTest extends AbstractTelnetOptionHandlerTest {
/**
* setUp for the test.
*/
diff --git
a/src/test/java/org/apache/commons/net/telnet/SuppressGAOptionHandlerTest.java
b/src/test/java/org/apache/commons/net/telnet/SuppressGAOptionHandlerTest.java
index f1b8e727..6f35a18f 100644
---
a/src/test/java/org/apache/commons/net/telnet/SuppressGAOptionHandlerTest.java
+++
b/src/test/java/org/apache/commons/net/telnet/SuppressGAOptionHandlerTest.java
@@ -19,7 +19,7 @@ package org.apache.commons.net.telnet;
/**
* JUnit test class for SuppressGAOptionHandler
*/
-public class SuppressGAOptionHandlerTest extends
TelnetOptionHandlerTestAbstract {
+public class SuppressGAOptionHandlerTest extends
AbstractTelnetOptionHandlerTest {
/**
* setUp for the test.
diff --git
a/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java
b/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java
index 7859e48d..1a9d3e2a 100644
---
a/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java
+++
b/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java
@@ -16,7 +16,7 @@
*/
package org.apache.commons.net.telnet;
-public class TerminalTypeOptionHandlerTest extends
TelnetOptionHandlerTestAbstract {
+public class TerminalTypeOptionHandlerTest extends
AbstractTelnetOptionHandlerTest {
/*
* compares two arrays of int
*/
diff --git
a/src/test/java/org/apache/commons/net/telnet/WindowSizeOptionHandlerTest.java
b/src/test/java/org/apache/commons/net/telnet/WindowSizeOptionHandlerTest.java
index 8fe0c716..badc1b95 100644
---
a/src/test/java/org/apache/commons/net/telnet/WindowSizeOptionHandlerTest.java
+++
b/src/test/java/org/apache/commons/net/telnet/WindowSizeOptionHandlerTest.java
@@ -19,7 +19,7 @@ package org.apache.commons.net.telnet;
/**
* JUnit test class for TerminalTypeOptionHandler
*/
-public class WindowSizeOptionHandlerTest extends
TelnetOptionHandlerTestAbstract {
+public class WindowSizeOptionHandlerTest extends
AbstractTelnetOptionHandlerTest {
/**
* compares two arrays of int
*/
