This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new 53bb929c8 Use Objects.equals()
53bb929c8 is described below

commit 53bb929c8f840a279f16cace5ce9567bb02a87aa
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jul 16 16:26:59 2023 -0400

    Use Objects.equals()
---
 src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java 
b/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
index b9a442a0e..4d481c565 100644
--- a/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
+++ b/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
@@ -114,7 +114,7 @@ public class DiffBuilder<T> implements 
Builder<DiffResult<T>> {
         this.style = style;
 
         // Don't compare any fields if objects equal
-        this.objectsTriviallyEqual = testTriviallyEqual && (lhs == rhs || 
lhs.equals(rhs));
+        this.objectsTriviallyEqual = testTriviallyEqual && Objects.equals(lhs, 
rhs);
     }
 
     /**
@@ -814,7 +814,7 @@ public class DiffBuilder<T> implements 
Builder<DiffResult<T>> {
         }
 
         // Not array type
-        if (lhs != null && lhs.equals(rhs)) {
+        if (Objects.equals(lhs, rhs)) {
             return this;
         }
 

Reply via email to