Author: billbarker Date: Fri May 22 02:33:12 2009 New Revision: 777356 URL: http://svn.apache.org/viewvc?rev=777356&view=rev Log: I've made SparseRealVector and SparseRealMatrix to be empty marker interfaces.
I've left OpenMapRealVector.getSparcity, since I'd like to use it for benchmarking, and it doesn't hurt anyone else now. Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealMatrix.java commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealVector.java commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealMatrix.java commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealMatrix.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealMatrix.java?rev=777356&r1=777355&r2=777356&view=diff ============================================================================== --- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealMatrix.java (original) +++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealMatrix.java Fri May 22 02:33:12 2009 @@ -286,9 +286,5 @@ return row * columnDimension + column; } - /** {...@inheritdoc} */ - public MatrixShape getShape() { - return MatrixShape.Any; - } } Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealVector.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealVector.java?rev=777356&r1=777355&r2=777356&view=diff ============================================================================== --- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealVector.java (original) +++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/OpenMapRealVector.java Fri May 22 02:33:12 2009 @@ -1297,7 +1297,10 @@ return true; } - /** {...@inheritdoc} */ + /** + * + * @return the percentage of none zero elements as a decimal percent. + */ public double getSparcity() { return (double)entries.size()/(double)getDimension(); } Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealMatrix.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealMatrix.java?rev=777356&r1=777355&r2=777356&view=diff ============================================================================== --- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealMatrix.java (original) +++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealMatrix.java Fri May 22 02:33:12 2009 @@ -25,16 +25,5 @@ * */ public interface SparseRealMatrix extends RealMatrix { - - /** - * Type to identify the shape of the matrix - */ - public static enum MatrixShape {Any}; - - /** - * - * @return the shape of the matrix - */ - MatrixShape getShape(); } Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java?rev=777356&r1=777355&r2=777356&view=diff ============================================================================== --- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java (original) +++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java Fri May 22 02:33:12 2009 @@ -24,10 +24,4 @@ */ public interface SparseRealVector extends RealVector { - /** - * - * @return the percentage of none zero elements as a decimal percent. - */ - double getSparcity (); - }