Author: sgoeschl
Date: Mon Feb 23 22:05:06 2009
New Revision: 747158
URL: http://svn.apache.org/viewvc?rev=747158&view=rev
Log:
[EXEC-37] Removed useless synchronized statement in
OpenVmsProcessingEnvironment.createProcEnvironment() since the method is only
called from a synchronized public method.
Modified:
commons/proper/exec/trunk/src/changes/changes.xml
commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/environment/OpenVmsProcessingEnvironment.java
Modified: commons/proper/exec/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/changes/changes.xml?rev=747158&r1=747157&r2=747158&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/changes/changes.xml (original)
+++ commons/proper/exec/trunk/src/changes/changes.xml Mon Feb 23 22:05:06 2009
@@ -24,6 +24,10 @@
</properties>
<body>
<release version="1.0.0" date="As in SVN" description="Sandbox release">
+ <action dev="sgoeschl" type="fix" due-to="Sebastien
Bazley"issue="EXEC-37">
+ Removed useless synchronized statement in
+ OpenVmsProcessingEnvironment.createProcEnvironment
+ </action>
<action dev="sgoeschl" type="fix" issue="EXEC-33">
Using System.in for child process will actually hang your application -
see JIRA for more details. Since there is no easy fix an
Modified:
commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/environment/OpenVmsProcessingEnvironment.java
URL:
http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/environment/OpenVmsProcessingEnvironment.java?rev=747158&r1=747157&r2=747158&view=diff
==============================================================================
---
commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/environment/OpenVmsProcessingEnvironment.java
(original)
+++
commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/environment/OpenVmsProcessingEnvironment.java
Mon Feb 23 22:05:06 2009
@@ -37,7 +37,7 @@
* @return a amp containing the environment variables
* @throws IOException the operation failed
*/
- protected synchronized Map createProcEnvironment() throws IOException {
+ protected Map createProcEnvironment() throws IOException {
if (procEnvironment == null) {
procEnvironment = new HashMap();
