Author: nicolas Date: Wed Mar 5 02:50:14 2008 New Revision: 633811 URL: http://svn.apache.org/viewvc?rev=633811&view=rev Log: fix some PMD violations
Modified: commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/ExecutionStack.java commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/Monitoring.java commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/AbstractPeriodicLogger.java commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/web/MonitoringServlet.java commons/sandbox/monitoring/trunk/src/test/java/org/apache/commons/monitoring/ExecutionStackTest.java Modified: commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/ExecutionStack.java URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/ExecutionStack.java?rev=633811&r1=633810&r2=633811&view=diff ============================================================================== --- commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/ExecutionStack.java (original) +++ commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/ExecutionStack.java Wed Mar 5 02:50:14 2008 @@ -20,8 +20,6 @@ import java.util.LinkedList; import java.util.List; -import org.apache.commons.monitoring.StopWatch; - /** * Sometime we need to compare elapsed time from a high level process with fine-grained * sub-processes to find bottlenecks or errors. The <code>ExecutionStack</code> allows Modified: commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/Monitoring.java URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/Monitoring.java?rev=633811&r1=633810&r2=633811&view=diff ============================================================================== --- commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/Monitoring.java (original) +++ commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/Monitoring.java Wed Mar 5 02:50:14 2008 @@ -18,7 +18,6 @@ package org.apache.commons.monitoring; import org.apache.commons.monitoring.impl.repositories.DefaultRepository; -import org.apache.commons.monitoring.StopWatch; /** * Utility class for simpified application instrumentation Modified: commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/AbstractPeriodicLogger.java URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/AbstractPeriodicLogger.java?rev=633811&r1=633810&r2=633811&view=diff ============================================================================== --- commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/AbstractPeriodicLogger.java (original) +++ commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/AbstractPeriodicLogger.java Wed Mar 5 02:50:14 2008 @@ -85,7 +85,7 @@ } catch (Exception exception) { - // catch any exception, as throwing it will stop the time + // catch any exception, as throwing it will stop the timer } } Modified: commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/web/MonitoringServlet.java URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/web/MonitoringServlet.java?rev=633811&r1=633810&r2=633811&view=diff ============================================================================== --- commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/web/MonitoringServlet.java (original) +++ commons/sandbox/monitoring/trunk/src/main/java/org/apache/commons/monitoring/reporting/web/MonitoringServlet.java Wed Mar 5 02:50:14 2008 @@ -18,12 +18,9 @@ package org.apache.commons.monitoring.reporting.web; import java.io.IOException; -import java.net.MalformedURLException; -import java.net.URL; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; -import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.StringTokenizer; Modified: commons/sandbox/monitoring/trunk/src/test/java/org/apache/commons/monitoring/ExecutionStackTest.java URL: http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/src/test/java/org/apache/commons/monitoring/ExecutionStackTest.java?rev=633811&r1=633810&r2=633811&view=diff ============================================================================== --- commons/sandbox/monitoring/trunk/src/test/java/org/apache/commons/monitoring/ExecutionStackTest.java (original) +++ commons/sandbox/monitoring/trunk/src/test/java/org/apache/commons/monitoring/ExecutionStackTest.java Wed Mar 5 02:50:14 2008 @@ -19,7 +19,6 @@ import junit.framework.TestCase; -import org.apache.commons.monitoring.impl.stopwatches.DefaultStopWatch; import org.apache.commons.monitoring.impl.stopwatches.ExecutionStopWatch; /**