JoaoJandre commented on PR #12758: URL: https://github.com/apache/cloudstack/pull/12758#issuecomment-4192182386
Hello, @vishesh92 Regarding your feedback, I have made some changes to the spec and code: 1. I have added the `finishBackupChain` API, that allows users to force a backup chain on a VM to end. This API may be called on VMs that are on the `BackupError` state and it will do a best-effort attempt at normalizing the VM and returning it to its original state, as well as finishing the backup chain on the VM. 2. I have added a sanitization step on the JSON that is passed to Qemu before executing the validation command. 3. I changed the `backup.validation.max.concurrent.operations` default to 10 instead of unlimited. This value may or may not make sense based on the size of the environment, but at least now we have a default global limit, instead of only a limit per host. I decided not to change the `enforce.resource.limit.on.backup.validation.vm` config default as, from the feedback I got from internal users, they will never want to use `enforce.resource.limit.on.backup.validation.vm` as `true`; still, the configuration exists as a form of flexibility. I have also changed the naming of the provider, now it is called KBOSS (KVM Backup on Secondary Storage) on the code, PR and specification. I will start to work on the unit tests, these should take some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
