Copilot commented on code in PR #12959:
URL: https://github.com/apache/cloudstack/pull/12959#discussion_r3032614985
##########
scripts/vm/hypervisor/kvm/gpudiscovery.sh:
##########
@@ -749,7 +749,7 @@ for LINE in "${LINES[@]}"; do
fi
# Only process GPU classes (3D controller)
- if [[ ! "$PCI_CLASS" =~ (3D\ controller|Processing\ accelerators) ]];
then
+ if [[ ! "$PCI_CLASS" =~ (3D\ controller|Processing\
accelerators|Display\ controller) ]]; then
continue
Review Comment:
The GPU-class filter still excludes `VGA compatible controller` even though
the script’s sample JSON at the top includes GPUs with `pci_class: "VGA
compatible controller"`. With the current regex, those devices will be silently
skipped by discovery. Consider expanding the class match (and updating the
nearby comment) to include VGA-compatible controllers as well, so the behavior
matches the documented output examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
