daviftorres commented on PR #12937: URL: https://github.com/apache/cloudstack/pull/12937#issuecomment-4163887197
> I have no idea if this is a sensible change @daviftorres , I cannot see the issue and do not see what the change entails in behavioural change. If a domain name contains regex metacharacters, renaming it can fail because the regex gets interpreted incorrectly. A proper solution already exists in this file (line 1118), so I reused that implementation. By the way, I’m fine if you decide not to proceed. I just wanted to point out an issue I came across, which could potentially lead to data corruption if certain conditions are met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
