daviftorres opened a new pull request, #12938: URL: https://github.com/apache/cloudstack/pull/12938
### Description The function `getUserByApiKey` does not check for `null` pointers. This is likely safe from a security perspective, but it’s still a code smell and should be improved. It can be fixed easily using the same approach as in line 3160. - I classified this as an issue type "bug", - Since missing API keys are a common and expected condition (not all users have API Keys set), - And I marked the severity as trivial because (in my limited understanding) it does not appear to have any real impact. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [X] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? No, it was not tested, it is just a static analysis of the code. #### How did you try to break this feature and the system with this change? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
