Pearl1594 commented on PR #12919: URL: https://github.com/apache/cloudstack/pull/12919#issuecomment-4163375173
I was wondering if it would make sense to guard this under a global setting like `vm.scale.allow.differing.host.tags`, which by default would be false, to keep the existing behaviour. The reason being, with this PR it definitely gives flexibility to scale to an offering with different host tags, but end users may not be able to tell from the list which offerings would actually work for them. For example, if a user's VM is currently on a GPU host and they want to scale up for more resources, they may see SSD offerings in the list (because the cluster has SSD hosts as well), but depending on whether their specific host has both GPU and SSD tags or just GPU, the scale operation may succeed or fail with a "host tags" error. A global setting would allow users to opt into this new behaviour while keeping the current behaviour as the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
