hsato03 commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r3012315282
##########
core/src/main/java/com/cloud/agent/api/storage/MigrateVolumeCommand.java:
##########
@@ -36,6 +36,7 @@ public class MigrateVolumeCommand extends Command {
String attachedVmName;
Volume.Type volumeType;
String hostGuidInTargetCluster;
+ Long newIops;
Review Comment:
@JoaoJandre @weizhouapache Yes, I think there was some misunderstanding when
using the terms `minIops` and `maxIops`, which are attributes of the storage
QoS type.
I changed both commands to use the `newReadRateIops` and `newWriteRateIops`
attributes, which are related to the hypervisor QoS type. Furthermore, this
approach makes the command agnostic, as you mentioned.
Could you take a look again, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
