MisterRaindrop commented on code in PR #2060:
URL: https://github.com/apache/cloudberry/pull/2060#discussion_r4175785916
##########
src/test/isolation2/sql/resgroup/resgroup_cpu_max_percent.sql:
##########
@@ -212,9 +216,11 @@ SELECT fetch_sample();
SELECT pg_sleep(1.7);
-- end_ignore
-SELECT verify_cpu_usage('rg1_cpu_test', 30, 10);
+-- Both groups are uncapped, so they share the whole machine in proportion
+-- to cpu_weight (100 and 200): ~33 and ~67, not ~30 and ~60.
Review Comment:
Nit: could we also update the earlier explanation in this test? It still
says the groups share 90% of the CPU and therefore expect 30%/60%, while the
new comment and assertions use 33%/67% because the suite CPU limit is 100%.
Keeping both explanations in the same test is contradictory. The
corresponding PAX copy should be updated too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
