reshke opened a new pull request, #2072:
URL: https://github.com/apache/cloudberry/pull/2072
With enable_answer_query_using_materialized_views=on, valid queries could
fail with "ORDER/GROUP BY expression not found in targetlist" (distinct from
#344/#582):
1. The parse->hasAggs && viewQuery->hasAggs branch assumed no GROUP BY on
either side, so an aggregate MV with a groupClause survived the tlist
replacement and left a dangling ressortgroupref. Decline such MVs.
2. The join exact-match rewrite dropped resjunk tlist entries but kept
sortClause, so an MV ordered by a column outside its SELECT list broke even its
exact defining query (2e27d4c2b3d fixed only the in-tlist case). Decline MVs
whose sortClause references dropped entries.
Example (MV: SELECT ... FROM t WHERE k IS NOT NULL GROUP BY k):
SELECT count(*) FROM t WHERE k IS NOT NULL;
ERROR: ORDER/GROUP BY expression not found in targetlist
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
