leborchuk opened a new pull request, #2069:
URL: https://github.com/apache/cloudberry/pull/2069

   Fix template generation here - queries on a foreign table failed with 
"ERROR: Unexpected exception in gpsc zero-length delimited identifier at or 
near """". The gpsc extension hooks ExecutorStart and normalizes the EXPLAIN 
VERBOSE plan text by running the core SQL lexer over it (gen_normplan). For a 
Foreign Scan the verbose plan embeds the FDW's Remote SQL, which contained an 
empty quoted identifier "" — a hard lexer error. gpsc converted this internal 
error into an ERROR that aborted the user's otherwise valid query. Adding the 
user to gpsc.ignored_users_list only bypassed gpsc processing.
   
   The PG error was already caught by PG_TRY/PG_CATCH inside wrap();
   We re-throw it as std::runtime_error only to catch it again in cpp_call and 
then fail query with ERROR.
   A stats collector must never interrupt user queries.
   We could check for exceptions, but it's useless - why we need to re-throw 
exception, what could we do on a caller side? Now wrappers just log a WARNING 
and return NULL instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to