Waloid24 opened a new pull request, #2067: URL: https://github.com/apache/cloudberry/pull/2067
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! --> ### What does this PR do? <!-- Brief overview of the changes, including any major features or fixes --> `CalcScaleFactorCumulativeConj()` already sorts scale factors in descending order, so sorting them at the call site performs the same work twice. Also remove the null assertion after `Append()`, since scale_factors has already been dereferenced at that point and is initialized earlier in the function. ### Type of Change - [x] Bug fix (non-breaking change) ### Test Plan <!-- How did you test these changes? --> - [ ] Passed `make installcheck` - [ ] Passed `make -C src/test installcheck-cbdb-parallel` ### Impact - Potentially improve performance due to the absence of an extra sort - Make code base cleaner - No user-facing changes - No dependencies changes ### Checklist - [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code) - [ ] Reviewed code for security implications - [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) ### CI Skip Instructions <!-- To skip CI builds, add the appropriate CI skip identifier to your PR title. The identifier must: - Be in square brackets [] - Include the word "ci" and either "skip" or "no" - Only use for documentation-only changes or when absolutely necessary --> --- <!-- Join our community: - Mailing list: [[email protected]](https://lists.apache.org/[email protected]) (subscribe: [email protected]) - Discussions: https://github.com/apache/cloudberry/discussions --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
