tuhaihe commented on PR #2063:
URL: https://github.com/apache/cloudberry/pull/2063#issuecomment-5903368939
## What
Two commits:
1. **Replace pg_cron's bitstring.h with the BSD-3 version.** pg_cron's copy
carries the pre-4.4BSD form of the University of California license, which
asks that documentation and advertising materials acknowledge UC Berkeley.
It is replaced verbatim with FreeBSD's `sys/sys/bitstring.h` from
stable/10:
the same Berkeley code after UC Berkeley deleted the advertising clause
(FreeBSD commit 82c6e8799148). RAT recognizes the new header, so its
exclude
is dropped.
2. **Register third-party code missing from LICENSE**, with the license texts
under `licenses/` (each copied verbatim from the source files or
upstream):
| Component | License |
|---|---|
| pg_cron's Vixie cron parts: `src/backend/task/entry.c`, `misc.c`,
`src/include/task/cron.h` | Paul Vixie's license |
| `src/include/task/bitstring.h` | BSD-3 (from FreeBSD stable/10) |
| Snowball stemmers and stop words | BSD-3 |
| `src/timezone/strftime.c` | BSD-3 (UC Regents) |
| pg_bsd_indent (`src/tools/pg_bsd_indent`) | BSD-3; `indent.h` is BSD-2 |
| HyperLogLog (`src/backend/lib/hyperloglog.c`, `.h`) | MIT |
| LLVM's SectionMemoryManager
(`src/backend/jit/llvm/SectionMemoryManager.cpp`,
`src/include/jit/SectionMemoryManager.h`) | Apache-2.0 with LLVM Exceptions |
| IANA time zone code and data | Public domain |
| Project X0213 mapping tables | Project X0213 license |
| `gb-18030-2000.xml` (from unicode-org/icu-data) | ICU license |
| cmockery (`src/test/unit/cmockery`) | Apache-2.0 |
`pom.xml` excludes the two license texts that RAT does not recognize
(Vixie cron, Project X0213).
## REL_2_STABLE
The REL_2_STABLE version is #2059. It has the same bitstring.h commit, but
its
LICENSE commit leaves out pg_bsd_indent and SectionMemoryManager, which do
not
exist on that branch. The LICENSE layout differs between the branches, so
these
are separate commits rather than cherry-picks.
## Verification
- bitstring.h: an exhaustive comparison of the old and new macros (137,664
checks, 0 mismatches): `bitstr_size`, plus `bit_nset`/`bit_nclear` for
every
(start, stop) in 64 bits, and `bit_set`/`bit_clear`/`bit_test` for every
bit.
- Full build on the rocky9 CI image with no warnings from the task files; the
`test_setup` and `task` regress tests pass on a demo cluster.
- All paths added to LICENSE exist.
- RAT on a clean export with submodules: no unapproved files apart from the
36
submodule docs that #2058 fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
