tuhaihe commented on PR #1987:
URL: https://github.com/apache/cloudberry/pull/1987#issuecomment-5636420246
I verified the claims against the pinned `tabulate` commit (`3a58301`) — Ryu
file list, paths,
license texts and the RAT excludes all check out. Two things to fix:
**1. The MIT carve-out is too broad for the amalgamated header**
`single_include/tabulate/tabulate.hpp` is named under "the bundled
third-party components listed
below", so it's now excluded from MIT entirely. But it's a composite file:
lines 1–5624 are the
three `*-lite` libs (BSL-1.0), ~5625–6071 termcolor (BSD-3), and ~6072–9385
are tabulate's own MIT
code (`SPDX-License-Identifier: MIT`). That last ~3,300 lines is now covered
by nothing.
Suggest making the carve-out apply to the embedded *portions*, not to whole
files:
contrib/pax_storage/src/cpp/contrib/tabulate
(tabulate's own code only; the third-party code bundled and embedded
within it is listed below under its own licenses)
see licenses/LICENSE-tabulate.txt
**2. `utils/amalgamate/` is still undeclared**
contrib/pax_storage/src/cpp/contrib/tabulate/utils/amalgamate/
`LICENSE.md` there is BSD-3-Clause, "Copyright (c) 2012, Erik Edlund" — same
situation as termcolor:
not tabulate's MIT, ships with the submodule, not in the root LICENSE. Worth
adding to the BSD 3
Clause section in the same pass.
(The two failing CI jobs are unrelated — no code changes here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
