my-ship-it commented on PR #1971:
URL: https://github.com/apache/cloudberry/pull/1971#issuecomment-5628469569
Fixed in ddaedff — thank you, both were real bugs and tracing them turned up
two more.
Neither string came from the handbook; both came from the generator that
converts it to
Docusaurus markdown. Chasing them found a third problem I would not have
caught otherwise:
- **`本节要点` (87 sections).** This line printed each section's internal `map`
keyword array.
The handbook's own renderer never displays that array — it only uses the
sibling `mapSkip`
flag to decide which sections appear in the "In this chapter" list. I
confirmed it with
jsdom: the string `cdbhash → segment` from §1.1's `map` exists only inside
the data
`<script>`, in no rendered element. So those 87 lines were content the
handbook does not
have, and translating them would have preserved the worse half of the bug.
**Dropped.**
- **`| 部分 | 含义 |` (10 field diagrams).** Invented table headers — the
handbook renders
these as label-plus-description cells with no header row at all. They are
a definition list
now, which needs no header text.
- **`:::info 参见` (1 cross-reference).** The handbook marks these with a CSS
`↔` prefix and no
word, so the admonition is untitled.
- The index page's own prose.
Separately, the handbook itself cited the Chinese edition of Rogov's
*PostgreSQL 14 Internals*
in three places. Two already carried English glosses — `自旋锁 (spinlock)` and
friends — which
made the Chinese redundant; a figure reference and one term did not. All
three are English now.
**Chinese characters under `docs/core-internals`: zero**, verified against
the pushed branch
file by file. Rebuilt against Docusaurus 3 / MDX v3: no compilation errors,
no broken links,
no broken anchors.
The PDF linked in the description is from before this fix; I will refresh it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
