75033us commented on code in PR #1970:
URL: https://github.com/apache/cloudberry/pull/1970#discussion_r3957331752
##########
src/backend/catalog/system_views.sql:
##########
@@ -165,6 +165,21 @@ CREATE VIEW pg_matviews AS
LEFT JOIN pg_tablespace T ON (T.oid = C.reltablespace)
WHERE C.relkind = 'm';
+CREATE VIEW gp_matviews AS
+ SELECT
+ A.mvoid,
+ N.nspname AS mvschema,
+ C.relname AS mvname,
+ A.has_foreign,
+ A.datastatus
+ FROM gp_matview_aux A
+ JOIN pg_class C ON (C.oid = A.mvoid)
+ LEFT JOIN pg_namespace N ON (N.oid = C.relnamespace);
+
+COMMENT ON VIEW gp_matviews IS 'Schema-qualified view of gp_matview_aux,
resolving mvname live from pg_class/pg_namespace instead of a stored copy.
Prefer this over gp_matview_aux.mvname, which is not schema-qualified (see
https://github.com/apache/cloudberry/issues/726).';
+
+COMMENT ON COLUMN gp_matview_aux.mvname IS 'Deprecated: bare,
non-schema-qualified materialized view name, retained for backward
compatibility only. Two materialized views with the same name in different
schemas are indistinguishable via this column. Use gp_matviews.mvname (with
gp_matviews.mvschema) instead. See
https://github.com/apache/cloudberry/issues/726.';
Review Comment:
Thank you for your feedback. Let me address this one, and also follow-up on
the test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
