yjhjstz commented on code in PR #1965:
URL: https://github.com/apache/cloudberry/pull/1965#discussion_r3946105575
##########
src/backend/postmaster/autovacuum.c:
##########
@@ -2957,6 +2957,16 @@ extract_autovac_opts(HeapTuple tup, TupleDesc
pg_class_desc)
relam != AO_COLUMN_TABLE_AM_OID)
return NULL;
+ /*
+ * AO reloptions use RELOPT_KIND_APPENDOPTIMIZED which does not include
+ * autovacuum reloptions, so the embedded AutoVacOpts is zero-filled.
+ * Returning it would make TOAST inherit freeze_max_age=0, triggering
+ * spurious aggressive wraparound vacuums. AO auxiliary and TOAST
+ * relations use the heap AM, so they are unaffected by this guard.
+ */
+ if (IsAccessMethodAO(relam))
Review Comment:
We can handle the IsAccessMethodAO(relam) case in the existing if condition
line 2955, so the additional check is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
