MisterRaindrop commented on PR #142: URL: https://github.com/apache/cloudberry-pxf/pull/142#issuecomment-5519337308
One cancellation race remains in `ReadServiceImpl`: `isCancelled()` is checked only before starting a fragment. If cancellation happens before `attachBridge()`, or `endIteration()` makes `getNext()` return `null`, the last/only fragment can finish without an exception and be reported as `Completed`, even though `pxf_cancel_backend()` returned a positive count. Please recheck cancellation after attaching the bridge and after the read loop, then throw an explicit cancellation exception. A blocking `getNext()` test can reproduce this deterministically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
