gongxun0928 commented on code in PR #1064: URL: https://github.com/apache/cloudberry/pull/1064#discussion_r2096862483
########## configure.ac: ########## @@ -1749,6 +1749,13 @@ fi AC_SUBST(LDAP_LIBS_FE) AC_SUBST(LDAP_LIBS_BE) +# for contrib/pax +if test "$enable_pax" = yes; then + if test "$enable_shared_postgres_backend" = no; then + AC_MSG_ERROR([pax support requires --enable-shared-postgres-backend]) + fi +fi + Review Comment: The dependencies of unit tests are also dependencies, just like we need to download googletest. By the way, this check does not add any additional overhead to the default behavior. The `enable_shared_postgres_backend` option is enabled by default. Unless `--disable_shared_postgres_backend` is explicitly specified, enabling `--enable-pax` will not fail due to this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
